Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy rook.io with Ceph and test it with a VM #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deploy rook.io with Ceph and test it with a VM #15

wants to merge 1 commit into from

Conversation

tiraboschi
Copy link
Contributor

@tiraboschi tiraboschi commented Nov 23, 2021 •
edited
Loading

Deploy rook.io with Ceph and test it with a VM

sandrobonazzola
sandrobonazzola approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 23, 2021
@openshift-ci openshift-ci bot removed the lgtm label Nov 23, 2021
@tiraboschi tiraboschi force-pushed the deploy_rook branch 2 times, most recently from 9cceaa9 to a1f362d Compare November 24, 2021 10:30
@tiraboschi tiraboschi changed the title Deploy rook Deploy rook.io with Ceph and test it with a VM Nov 24, 2021
sandrobonazzola
sandrobonazzola approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 24, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sandrobonazzola, tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sandrobonazzola,tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Nov 24, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2021

New changes are detected. LGTM label has been removed.

@tiraboschi
Copy link
Contributor Author

/retest

fabiand
fabiand reviewed Nov 25, 2021
View reviewed changes
hack/vm_fedora35_rookceph.yaml
creationTimestamp: null
name: fedora-35-test
spec:
pvc:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably want to start using the storage api here.

@tiraboschi tiraboschi force-pushed the deploy_rook branch 10 times, most recently from a3ad3ff to 1346cd8 Compare November 30, 2021 19:31
@tiraboschi
Copy link
Contributor Author

/retest

2 similar comments
@tiraboschi
Copy link
Contributor Author

/retest

@tiraboschi
Copy link
Contributor Author

/retest

@tiraboschi tiraboschi force-pushed the deploy_rook branch 4 times, most recently from 421d190 to 29e9396 Compare December 2, 2021 08:51
@tiraboschi
Deploy rook.io with Ceph and test it with a VM
2d65140 
Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@tiraboschi
Copy link
Contributor Author

/retest

3 similar comments
@tiraboschi
Copy link
Contributor Author

/retest

@tiraboschi
Copy link
Contributor Author

/retest

@tiraboschi
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2021

@tiraboschi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-pres-e2e-deploy 2d65140 link true /test okd-pres-e2e-deploy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sandrobonazzola sandrobonazzola removed their assignment Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiand fabiand fabiand left review comments

@sandrobonazzola sandrobonazzola sandrobonazzola approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiraboschi @fabiand @sandrobonazzola