Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken user and channel mentions in blockquotes in chat markdown #2467

Closed
taoeffect opened this issue Dec 16, 2024 · 0 comments · Fixed by #2480
Closed

Broken user and channel mentions in blockquotes in chat markdown #2467

taoeffect opened this issue Dec 16, 2024 · 0 comments · Fixed by #2480

Comments

@taoeffect
Copy link
Member

taoeffect commented Dec 16, 2024

Problem

Following up on PR #2458, one bug remains (copy/pasting):

It seems the logic for @mentions and channel name mentions is a bit wonky too, as sometimes it works, and sometimes it doesn't:

Markdown:

> @u1 Test #general 

And

> `another () => test` of the
> 
> ```
> emergency () => system
> and
> 
> break
> ```
> 
> But what about
> Paragraph breaks
> That are empty
> 
> Like this one @u1 #general 

() => test

Result:

Screenshot 2024-12-16 at 10 26 03 AM

Github (checking to see if it handles @U1...):

@U1 Test #general

And

another () => test of the

emergency () => system
and

break

But what about
Paragraph breaks
That are empty

Like this one @U1 #general

() => test

Solution

Make it so that user and channel mentions are properly highlighted in this other scenario too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants