Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat doesn't render blockquotes in chat anymore #2457

Closed
taoeffect opened this issue Dec 13, 2024 · 0 comments · Fixed by #2458
Closed

Chat doesn't render blockquotes in chat anymore #2457

taoeffect opened this issue Dec 13, 2024 · 0 comments · Fixed by #2458
Assignees
@SebinSong
Labels
App:Frontend Kind:Bug Note:UI/UX Priority:High

Comments

@taoeffect
Copy link
Member

Problem

Here's a bit of markdown:

> test

test

Here's how it's rendered in the chat:

Screenshot 2024-12-13 at 3 54 34 PM

And here's how it's supposed to render:

test

test

Solution

Update the markdown renderer to properly restore rendering quote strings. (I think this used to work? What happened?)
@SebinSong SebinSong mentioned this issue Dec 14, 2024
Merged
taoeffect pushed a commit that referenced this issue Dec 16, 2024
@SebinSong
#2457 - Fix the broken blockquotes in the chat markdown (#2458)
2223594 
* markdown bugfix for the broken blockquotes

* add edge-case handling logic

* remove console.log

* fix the linter err

* comment update

* comment update for flaky test

* handle blank-line within the blockquotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SebinSong SebinSong

Labels
App:Frontend Kind:Bug Note:UI/UX Priority:High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2457 - Fix the broken blockquotes in the chat markdown okTurtles/group-income
2 participants
@taoeffect @SebinSong