Skip to content

Commit

Permalink
[cron] sleep random seconds (<59), if not interactive or forced
Browse files Browse the repository at this point in the history
acmesh-official#944 (comment)

Let's Encrypt employee said in the comments "we do see peaks at the beginning of minutes and even seconds; the finer-grained time randomization, the better."

This adds a random amount of sleep second before beginning the cron job. I considered reading from `/dev/urandom` and so on, but we aren't doing anything security critical here so I thought that just using the process number modulo 59 (the largest prime <= 60) should give decent variability across the systems. The starting hour and minute are already randomized during the installation.
  • Loading branch information
oittaa authored Jul 20, 2024
1 parent 0f61e9c commit 795d987
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions acme.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6737,6 +6737,11 @@ cron() {
export _ACME_IN_CRON=1
_initpath
_info "$(__green "===Starting cron===")"
if [ -z "$FORCE" ] && [ -z "$__INTERACTIVE" ]; then
random_sec=$(_math $$ % 59)
_info "Sleeping for $random_sec seconds."
_sleep $random_sec
fi
if [ "$AUTO_UPGRADE" = "1" ]; then
export LE_WORKING_DIR
(
Expand Down

0 comments on commit 795d987

Please sign in to comment.