Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename resources to users; disable heatmap #9693

Merged
merged 5 commits into from
Jan 3, 2025

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jan 3, 2025

ohcnetwork/care#2701

Summary by CodeRabbit

  • Configuration Changes

    • Disabled default availability statistics API in care configuration
  • API Modifications

    • Removed appointment-related API routes
    • Updated API endpoints to use "user" instead of "resource"
    • Introduced new PublicAppointmentApi for appointment scheduling
  • Component Updates

    • Renamed references from "resource" to "user" across multiple components
    • Updated name formatting for practitioners
    • Simplified some component prop structures
  • New Features

    • Added CancelAppointmentRequest interface for appointment cancellations
  • Refactoring

    • Standardized terminology and data structures related to user and appointment handling

@rithviknishad rithviknishad requested a review from a team as a code owner January 3, 2025 10:36
@rithviknishad rithviknishad marked this pull request as draft January 3, 2025 10:36
Copy link
Contributor

coderabbitai bot commented Jan 3, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces a comprehensive refactoring of appointment-related components and APIs, focusing on replacing resource with user terminology across multiple files. The changes span configuration settings, API definitions, component implementations, and type interfaces. The primary objectives appear to be standardizing naming conventions, updating API interactions, and introducing a new PublicAppointmentApi module to centralize appointment-related endpoint definitions.

Changes

File/Group Change Summary
care.config.ts Changed useAvailabilityStatsAPI default value from true to false
src/Utils/request/api.tsx Removed API routes for getSlotsForDay, getAppointments, and createAppointment
Appointment Components Updated references from resource to user in multiple components like FollowUpAppointmentQuestion, AppointmentCreatePage, AppointmentDetailsPage
src/components/Schedule/api.ts Renamed availableDoctors to availableUsers and updated API endpoint paths
src/components/Schedule/types.ts Replaced resource with user in interfaces, added CancelAppointmentRequest interface
Appointment Pages Introduced PublicAppointmentApi import and updated query functions in pages like PatientRegistration, PatientSelect, Schedule, Success
src/types/scheduling/PublicAppointmentApi.ts New file defining public appointment API endpoints

Suggested labels

needs review, needs testing

Suggested reviewers

  • Jacobjeevan
  • shivankacker

Poem

🐰 Hop, hop, through code's winding trail,
Renaming "resource" without a wail
From doctors to users, we dance and we sing
Refactoring's magic, let API bells ring!
A rabbit's delight in clean, crisp design 🔧


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 39c4c52 and 716e1b0.

📒 Files selected for processing (20)
  • care.config.ts (1 hunks)
  • src/Utils/request/api.tsx (0 hunks)
  • src/components/Questionnaire/QuestionTypes/FollowUpAppointmentQuestion.tsx (2 hunks)
  • src/components/Schedule/Appointments/AppointmentCreatePage.tsx (2 hunks)
  • src/components/Schedule/Appointments/AppointmentDetailsPage.tsx (2 hunks)
  • src/components/Schedule/Appointments/AppointmentTokenCard.tsx (2 hunks)
  • src/components/Schedule/Appointments/AppointmentsPage.tsx (6 hunks)
  • src/components/Schedule/Appointments/utils.ts (3 hunks)
  • src/components/Schedule/ScheduleExceptionForm.tsx (1 hunks)
  • src/components/Schedule/ScheduleExceptionsList.tsx (3 hunks)
  • src/components/Schedule/ScheduleTemplateForm.tsx (1 hunks)
  • src/components/Schedule/api.ts (2 hunks)
  • src/components/Schedule/types.ts (3 hunks)
  • src/components/Users/UserAvailabilityTab.tsx (2 hunks)
  • src/pages/Appoinments/PatientRegistration.tsx (2 hunks)
  • src/pages/Appoinments/PatientSelect.tsx (2 hunks)
  • src/pages/Appoinments/Schedule.tsx (2 hunks)
  • src/pages/Appoinments/Success.tsx (2 hunks)
  • src/pages/Patient/index.tsx (4 hunks)
  • src/types/scheduling/PublicAppointmentApi.ts (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 716e1b0
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6777e9babc5f9e0008d0455f
😎 Deploy Preview https://deploy-preview-9693--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Jan 3, 2025

Deploying care-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 716e1b0
Status: ✅  Deploy successful!
Preview URL: https://a647cdb6.care-fe.pages.dev
Branch Preview URL: https://rithviknishad-schedule-valid.care-fe.pages.dev

View logs

Copy link

cypress bot commented Jan 3, 2025

CARE    Run #4155

Run Properties:  status check passed Passed #4155  •  git commit 5d06224467: Scheduling changes as per BE
Project CARE
Branch Review rithviknishad/schedule-validations
Run status status check passed Passed #4155
Run duration 01m 15s
Commit git commit 5d06224467: Scheduling changes as per BE
Committer Rithvik Nishad
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@rithviknishad rithviknishad changed the title Scheduling changes as per BE Rename resources to users; disable heatmap Jan 3, 2025
@rithviknishad rithviknishad marked this pull request as ready for review January 3, 2025 13:33
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


import { Type } from "@/Utils/request/api";

export const PublicAppointmentAPIs = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets make it the defualt export, also rename the file to match the api name

@bodhish bodhish merged commit 1d6ae92 into develop Jan 3, 2025
20 of 21 checks passed
@bodhish bodhish deleted the rithviknishad/schedule-validations branch January 3, 2025 13:46
Copy link

github-actions bot commented Jan 3, 2025

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants