Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal scroll bar used #9692

Merged

Conversation

NikhilA8606
Copy link
Contributor

@NikhilA8606 NikhilA8606 commented Jan 3, 2025

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Summary by CodeRabbit

  • Style
    • Improved organization name display in selector
    • Added styling to prevent text wrapping and enable horizontal overflow for organization names

@NikhilA8606 NikhilA8606 requested a review from a team as a code owner January 3, 2025 10:22
Copy link
Contributor

coderabbitai bot commented Jan 3, 2025

Walkthrough

The pull request introduces a minor UI modification to the OrganizationSelector component in the organization selection interface. A new div wrapper is added around the level.name display within the InputWithError component, specifically designed to control text overflow and prevent multi-line rendering of organization names. This change aims to improve the visual presentation of organization names by ensuring they remain on a single horizontal line.

Changes

File Change Summary
src/pages/Organization/components/OrganizationSelector.tsx Added a div wrapper around level.name with classes to manage horizontal overflow and prevent text wrapping

Suggested labels

needs review, tested

Suggested reviewers

  • rithviknishad

Possibly related PRs

Poem

🐰 A rabbit's tale of UI delight,
Where text flows smooth and lines stay tight,
No wrapping names, no messy view,
Just clean design, both sleek and true!
Hop along, code rabbit's might! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 39c4c52 and 6fd7418.

📒 Files selected for processing (1)
  • src/pages/Organization/components/OrganizationSelector.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/pages/Organization/components/OrganizationSelector.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 6fd7418
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6777ba80c3e8780008111f39
😎 Deploy Preview https://deploy-preview-9692--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bodhish
Copy link
Member

bodhish commented Jan 3, 2025

I am not sure on what it solves?

@NikhilA8606
Copy link
Contributor Author

NikhilA8606 commented Jan 3, 2025

I am not sure on what it solves?

image

I added Horizontal scroll bar for Local body it avoid the overflow of text

@cbum-dev
Copy link
Contributor

cbum-dev commented Jan 3, 2025

I am not sure on what it solves?

image

I added Horizontal scroll bar for Local body it avoid the overflow of text

I have raised a PR against the same issue earlier.
#9691

@NikhilA8606
Copy link
Contributor Author

NikhilA8606 commented Jan 3, 2025

This issue is assigned to me

@Jacobjeevan
Copy link
Contributor

@NikhilA8606 Mention the issue # in the PR and make sure to complete the merge checklist.

@github-actions github-actions bot added needs-triage question Further information is requested labels Jan 3, 2025
@NikhilA8606 NikhilA8606 changed the title Horizontal scroll bar used Horizontal scroll bar used #9690 Jan 3, 2025
@NikhilA8606 NikhilA8606 changed the title Horizontal scroll bar used #9690 Horizontal scroll bar used Jan 3, 2025
@NikhilA8606 NikhilA8606 changed the title Horizontal scroll bar used Overflowing text in input box #9690 Jan 3, 2025
@NikhilA8606
Copy link
Contributor Author

@NikhilA8606 Mention the issue # in the PR and make sure to complete the merge checklist.

okay

@NikhilA8606 NikhilA8606 changed the title Overflowing text in input box #9690 Horizontal scroll bar used Jan 3, 2025
@rithviknishad
Copy link
Member

Instead of scroll, can we truncate the text instead?

The full text can be shown as a tooltip instead.

@NikhilA8606
Copy link
Contributor Author

NikhilA8606 commented Jan 3, 2025

image
Is it what you meant @rithviknishad ?

@bodhish bodhish merged commit ccbc92d into ohcnetwork:develop Jan 3, 2025
73 checks passed
Copy link

github-actions bot commented Jan 3, 2025

@NikhilA8606 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflowing text in input box
5 participants