Fix: Notification close button added #9675

Rishith25 · 2025-01-02T18:18:51Z

Proposed Changes

Fixes Add close button to the notification #9657
Added the close button in the notifications

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Enhanced toast notifications by adding a close button to improve user interaction and control.
Documentation
- Updated comments for clarity regarding the toastOptions property functionality.

coderabbitai · 2025-01-02T18:18:59Z

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the toastOptions configuration in the App.tsx file by adding a closeButton property set to true for the Sonner component. This change enables users to manually close notification popups, providing more control over the notification display in the application.

Changes

File	Change Summary
`src/App.tsx`	Updated `toastOptions` to include `{ closeButton: true }` for Sonner toast notifications

Assessment against linked issues

Objective	Addressed	Explanation
Add close button to notifications [#9657]	✅
Allow manual dismissal of notification popups [#9657]	✅
Provide user control over notification display [#9657]	✅

Possibly related PRs

Fix Notification Subscription Loading and Messaging Errors #9038: Modifies notification subscription logic and enhances user feedback related to notifications.

Suggested labels

needs review, tested

Suggested reviewers

shivankacker
khavinshankar

Poem

🐰 A toast to toasts, with close in sight,
No more waiting, user's delight!
A button small, yet mighty clear,
Dismiss the pop-ups without fear.
Notifications bow to user's might! 🎉

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between af31a21 and 92d7b41.

📒 Files selected for processing (1)

src/App.tsx (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-02T18:19:10Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`92d7b41`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/677782de3043530008bd3c48
😎 Deploy Preview	https://deploy-preview-9675--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad

use global setting instead that can be passed to Sonner in App.tsx itself?

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Utils/Notifications.ts (1)

53-53: Error message text might need localization.

The error message displayed to end users may need to be translated if the application must support multiple languages. Consider extracting the error message strings into the i18n files or a localization-friendly approach.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34d7cbb and 94f3aea.

📒 Files selected for processing (1)

src/Utils/Notifications.ts (3 hunks)

🔇 Additional comments (3)

src/Utils/Notifications.ts (3)

22-30: Nice centralization of notification logic.

This new function effectively abstracts the various toast calls into a single utility, enhancing maintainability and making it straightforward to add more notification features (e.g., custom icons). One small suggestion: ensure any user-facing text (e.g., close button labeling) is handled or verified for proper internationalization, if applicable.

61-61: Straightforward usage of the new toastNotification.

It’s good to see consistency in the toast usage. Proceed with verifying that any user-facing text is stored in i18n files or a localization mechanism if your project requires it.

77-77: Consistent approach for warnings.

Similarly to success and error notifications, this refactor unifies the way warnings are displayed. Code remains consistent and clear.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/App.tsx (1)

67-67: Consider providing an accessible label for the close button.

While enabling the close button is a great enhancement, ensure that screen readers can properly announce the button’s purpose. For instance, add an aria-label or related prop to improve accessibility and match I18n best practices, if needed.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94f3aea and af31a21.

📒 Files selected for processing (1)

src/App.tsx (1 hunks)

src/App.tsx

github-actions · 2025-01-03T06:26:09Z

@Rishith25 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Rishith25 · 2025-01-03T07:17:14Z

@Jacobjeevan @rithviknishad Can you assign story points for this

Jacobjeevan · 2025-01-03T08:31:53Z

@Jacobjeevan @rithviknishad Can you assign story points for this

Already assigned; no points since it's a small change.

Notification close button added

94f3aea

Rishith25 requested a review from a team as a code owner January 2, 2025 18:18

rithviknishad requested changes Jan 2, 2025

View reviewed changes

coderabbitai bot reviewed Jan 2, 2025

View reviewed changes

Notification close button added

af31a21

Rishith25 requested a review from rithviknishad January 2, 2025 18:28

coderabbitai bot reviewed Jan 2, 2025

View reviewed changes

rithviknishad approved these changes Jan 3, 2025

View reviewed changes

src/App.tsx Outdated Show resolved Hide resolved

Update src/App.tsx

92d7b41

rithviknishad merged commit a2e92fd into ohcnetwork:develop Jan 3, 2025
8 of 11 checks passed

This was referenced Jan 4, 2025

Replaced ButtonV2's with Button in entire codebase #9736

Merged

Fixed : Delete Button in Schedules #9739

Closed

Updated Auto-Hide Functionality for Sidebar #9773

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Notification close button added #9675

Fix: Notification close button added #9675

Rishith25 commented Jan 2, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 2, 2025 •

edited

Loading

Review failed

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 2, 2025 •

edited

Loading

rithviknishad left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

github-actions bot commented Jan 3, 2025

Rishith25 commented Jan 3, 2025 •

edited

Loading

Jacobjeevan commented Jan 3, 2025

Fix: Notification close button added #9675

Fix: Notification close button added #9675

Conversation

Rishith25 commented Jan 2, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Jan 2, 2025 • edited Loading

Review failed

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 2, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

rithviknishad left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 3, 2025

Rishith25 commented Jan 3, 2025 • edited Loading

Jacobjeevan commented Jan 3, 2025

Rishith25 commented Jan 2, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 2, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 2, 2025 •

edited

Loading

Rishith25 commented Jan 3, 2025 •

edited

Loading