Appointments: redirect to patient page post update status to in_consultation

[rithviknishad]

Proposed Changes

• Appointments: redirect to patient page post update status to in_consultation

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Summary by CodeRabbit

• New Features

  • Added a dedicated function for navigating to patient verification page when an appointment status is updated
  • Improved navigation logic within appointment details management

• Refactor

  • Streamlined appointment status update mutation with more precise type definitions
  • Enhanced code clarity by extracting navigation logic into a separate function

[coderabbitai]

Walkthrough

The pull request introduces a refactoring of navigation logic within the AppointmentDetailsPage component. A new function redirectToPatientPage is added to encapsulate patient page navigation, replacing inline navigation logic. The updateAppointment mutation's type signature is updated to provide more precise type definitions, specifying the expected return and input types. The changes aim to improve code clarity and reusability by extracting and standardizing the navigation mechanism.

Changes

File	Change Summary
src/components/Schedule/Appointments/AppointmentDetailsPage.tsx	- Added redirectToPatientPage function for patient page navigation - Updated mutation type signature with explicit Appointment types - Refactored onViewPatient prop to use new navigation function

Possibly related PRs

• Fix: Breadcrumbs redirection to patient edit consultation form #8985: Breadcrumbs navigation changes potentially related to navigation logic
• Fixes timestamp alignment and adds 'Last Modified' section in patient management #9397 #9410: ConsultationDetails component modifications involving patient management
• Fixed Redirection of Critical care updation #9453: Navigation path alterations in DailyRounds component

Suggested labels

tested, needs review

Suggested reviewers

• Jacobjeevan

Poem

🐰 A rabbit's tale of code so neat,
Navigation paths now clean and sweet
Mutations typed with loving care
Redirects dancing through the air
Refactoring hops with joyful might! 🚀

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	44a9800
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/6776c36709e7bc000811d651
😎 Deploy Preview	https://deploy-preview-9672--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[cloudflare-workers-and-pages]

Deploying care-fe with    Cloudflare Pages

Latest commit:	44a9800
Status:	✅  Deploy successful!
Preview URL:	https://881f7684.care-fe.pages.dev
Branch Preview URL:	https://rithviknishad-fix-redirect-t.care-fe.pages.dev

View logs

[cypress]

CARE    Run #4143

Run Properties:   Passed #4143  •  44a980008d: Appointments: redirect to patient page post update status to in_consultation

Project	CARE
Branch Review	rithviknishad/fix/redirect-to-patient-page
Run status	Passed #4143
Run duration	01m 08s
Commit	44a980008d: Appointments: redirect to patient page post update status to in_consultation
Committer	Rithvik Nishad
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	3
View all changes introduced in this branch ↗︎

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/Schedule/Appointments/AppointmentDetailsPage.tsx (1)

85-94: Consider adding null checks or fallback logic for patient properties
If, in rare scenarios, appointment.patient is missing or lacks the required properties (e.g., phone_number), referencing it could cause runtime errors. You may consider adding defensive checks or fallback values.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 328fedc and 44a9800.

📒 Files selected for processing (1)

• src/components/Schedule/Appointments/AppointmentDetailsPage.tsx (2 hunks)

🔇 Additional comments (3)

src/components/Schedule/Appointments/AppointmentDetailsPage.tsx (3)

95-99: Good practice specifying mutation type parameters
Explicitly defining the expected return and input types for useMutation enhances type safety and maintainability.

---

106-112: Redirect logic on success is clear and concise
The conditional redirection based on request.status === "in_consultation" is clear. No improvements needed here.

---

180-180: Reusing navigation logic promotes maintainability
Passing redirectToPatientPage instead of inline navigation ensures better code reusability and clarity. Good job!

[github-actions]

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌