Fix avatar in facility list #9580

AdityaJ2305 · 2024-12-26T11:08:37Z

Proposed Changes

Fixes Display Facility Cover Image in Mobile View on the Facility Tab #9577
Change 1
Change 2
More?

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Request for Peer Reviews

Summary by CodeRabbit

New Features
- Updated the visibility and layout of links in the FacilityCard component for improved navigation.
Bug Fixes
- Simplified visibility logic for better responsiveness.

coderabbitai · 2024-12-26T11:08:45Z

Walkthrough

The pull request modifies the FacilityCard component in the src/components/Facility/FacilityCard.tsx file. The changes focus on adjusting the Link components' visibility and dimensions using media queries. The modifications aim to improve the component's responsiveness and layout, potentially addressing mobile view display issues for facility cover images.

Changes

File	Change Summary
`src/components/Facility/FacilityCard.tsx`	- Updated `Link` component class to use media query for visibility - Modified `Link` component dimensions from fixed pixels to `10rem` - Simplified visibility logic for component layout

Assessment against linked issues

Objective	Addressed	Explanation
Display Facility Cover Image in Mobile View [#9577]	❓	Changes appear related to mobile view, but full verification requires visual testing

Suggested Labels

needs review, tested

Suggested Reviewers

khavinshankar
rithviknishad

Poem

🐰 A rabbit's tale of pixels and grace,
Where mobile views find their rightful place,
Link components dance with query's might,
Responsive design takes playful flight,
Cover images now shine so bright! 🖼️

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cb80c0e and 881263b.

📒 Files selected for processing (1)

src/components/Facility/FacilityCard.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/components/Facility/FacilityCard.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2024-12-26T11:09:20Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`4126905`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/677245b04a58160008ebed6f
😎 Deploy Preview	https://deploy-preview-9580--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/components/Facility/FacilityCard.tsx (1)

80-80: Sync the avatar visibility with standard breakpoints
While switching from sm:block to min-[450px]:block, confirm that this new breakpoint doesn't collide with or create gaps between standard Tailwind breakpoints (e.g., sm at 640px). Ensure consistent behavior across various display widths.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20fe265 and 8a43e61.

📒 Files selected for processing (1)

src/components/Facility/FacilityCard.tsx (2 hunks)

🔇 Additional comments (1)

src/components/Facility/FacilityCard.tsx (1)

66-66: Confirm custom Tailwind breakpoints alignment
You're using the custom min-[450px] breakpoint here. Double-check that your Tailwind configuration supports this custom breakpoint so that the responsiveness works correctly as expected.

src/components/Facility/FacilityCard.tsx

bodhish · 2024-12-26T15:11:50Z

@AdityaJ2305 make sure you complete Merge Checklist

src/components/Facility/FacilityCard.tsx

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

tailwind.config.js

github-actions · 2024-12-31T06:37:32Z

👋 Hi, @AdityaJ2305,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

rithviknishad · 2024-12-31T07:32:40Z

we don't have this page in new arch.

Fix avatar in facility list

d95b8eb

AdityaJ2305 marked this pull request as ready for review December 26, 2024 11:08

AdityaJ2305 requested a review from a team as a code owner December 26, 2024 11:08

Merge branch 'develop' into issue/9577/facility_cover_image

8a43e61

coderabbitai bot reviewed Dec 26, 2024

View reviewed changes

rithviknishad requested changes Dec 26, 2024

View reviewed changes

src/components/Facility/FacilityCard.tsx Outdated Show resolved Hide resolved

moved to rem

ec13200

rithviknishad added needs testing needs review labels Dec 26, 2024

Merge branch 'develop' into issue/9577/facility_cover_image

b7a3ea1

rithviknishad reviewed Dec 26, 2024

View reviewed changes

src/components/Facility/FacilityCard.tsx Outdated Show resolved Hide resolved

AdityaJ2305 and others added 2 commits December 26, 2024 21:19

Update src/components/Facility/FacilityCard.tsx

4b1f446

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

full width view in sm

cb80c0e

rithviknishad requested changes Dec 27, 2024

View reviewed changes

tailwind.config.js Outdated Show resolved Hide resolved

rithviknishad added changes required and removed needs testing needs review labels Dec 27, 2024

Jacobjeevan mentioned this pull request Dec 27, 2024

Fix: UI issue in facilities page #9594

Closed

6 tasks

AdityaJ2305 added 2 commits December 28, 2024 01:57

use arbitrary value

82ef112

Merge branch 'develop' into issue/9577/facility_cover_image

881263b

AdityaJ2305 requested a review from rithviknishad December 27, 2024 20:28

AdityaJ2305 added 3 commits December 28, 2024 18:35

Merge branch 'develop' into issue/9577/facility_cover_image

caa8040

Merge branch 'develop' into issue/9577/facility_cover_image

020f592

Merge branch 'develop' into issue/9577/facility_cover_image

4126905

github-actions bot added the merge conflict pull requests with merge conflict label Dec 31, 2024

rithviknishad closed this Dec 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix avatar in facility list #9580

Fix avatar in facility list #9580

AdityaJ2305 commented Dec 26, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 26, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Dec 26, 2024 •

edited

Loading

coderabbitai bot left a comment

bodhish commented Dec 26, 2024

github-actions bot commented Dec 31, 2024

rithviknishad commented Dec 31, 2024 •

edited

Loading

Fix avatar in facility list #9580

Fix avatar in facility list #9580

Conversation

AdityaJ2305 commented Dec 26, 2024 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Dec 26, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Suggested Labels

Suggested Reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Dec 26, 2024 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

bodhish commented Dec 26, 2024

github-actions bot commented Dec 31, 2024

rithviknishad commented Dec 31, 2024 • edited Loading

AdityaJ2305 commented Dec 26, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 26, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Dec 26, 2024 •

edited

Loading

rithviknishad commented Dec 31, 2024 •

edited

Loading