Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes spacing issue in patient list phone number field and search inputs #8185

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Fixes spacing issue in patient list phone number field and search inputs #8185

merged 3 commits into from
Jul 22, 2024

Conversation

rithviknishad
Copy link
Member

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner July 22, 2024 09:54
@vercel Vercel
Copy link

vercel bot commented Jul 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 10:21am

@netlify Netlify
Copy link

netlify bot commented Jul 22, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7047edd
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/669e32762063e70008759eb5
😎 Deploy Preview https://deploy-preview-8185--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress Cypress
Copy link

cypress bot commented Jul 22, 2024 •
edited
Loading

Passing run #2921 ↗︎

0 126 0 0 Flakiness 0

Details:

Fixes spacing issue in patient list phone number field and search inputs
Project: CARE Commit: 7047edd6c2
Status: Passed Duration: 03:07 💡
Started: Jul 22, 2024 10:25 AM Ended: Jul 22, 2024 10:28 AM

Review all test suite changes for PR #8185 ↗︎

@nihal467
Copy link
Member

Co-related issue opened : #8189

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit dd4ad7b into develop Jul 22, 2024
61 of 62 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/8181 branch July 22, 2024 10:50
@github-actions GitHub Actions
Copy link

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

@nihal467 nihal467 mentioned this pull request Jul 22, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reposition the error message for phone number field
3 participants
@rithviknishad @nihal467 @khavinshankar