Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwinds Patient Home (Confirm Transfer Complete Dialog) #5662

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jun 13, 2023

WHAT

🤖 Generated by Copilot at c0136e3

Refactor PatientHome component to use common UI components and clean up code.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at c0136e3

  • Remove unused imports of CircularProgress, Dialog, DialogActions, DialogTitle, LegacyErrorHelperText and Modal from various components (link, link)
  • Add imports of CircularProgress, Page, ConfirmDialogV2 and FieldErrorText from common components to provide consistent UI elements (link)
  • Replace div element with Page component to render page title, breadcrumbs and back button with common layout and styling (link, link)
  • Remove size prop from CircularProgress components, as it is not needed for the default size (link, link)
  • Replace Modal and Dialog components with ConfirmDialogV2 component to render confirmation dialogs with common UI elements and props (link, link, link, link)
  • Replace LegacyErrorHelperText component with FieldErrorText component to render error text with consistent UI element (link)
  • Close Page component tag (link)

@rithviknishad rithviknishad requested a review from a team June 13, 2023 17:30
@rithviknishad rithviknishad requested a review from a team as a code owner June 13, 2023 17:30
@rithviknishad rithviknishad requested a review from gigincg June 13, 2023 17:30
@vercel
Copy link

vercel bot commented Jun 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2023 5:30pm

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c0136e3
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6488a7a00032fd00087cbdd4
😎 Deploy Preview https://deploy-preview-5662--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added cypress failed pull request with cypress test failure cypress passed and removed cypress failed pull request with cypress test failure labels Jun 13, 2023
@rithviknishad rithviknishad changed the title Tailwinds Patient Home Tailwinds Patient Home (Confirm Transfer Complete Dialog) Jun 17, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 99c8329 into develop Jun 21, 2023
@khavinshankar khavinshankar deleted the tailwind/4979 branch June 21, 2023 06:35
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Patient/PatientHome.tsx:
3 participants