Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the discharged logic in patient consultation dashboard #5379

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Apr 24, 2023

WHAT

🤖 Generated by Copilot at 30e3c3e

This pull request fixes some issues and improves some features related to the discharge functionality of consultations. It makes the discharge button more consistent and intuitive in ConsultationDetails.tsx, and it prevents inappropriate actions for discharged consultations in PatientInfoCard.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 30e3c3e

  • Reorder and group imports by type in ConsultationDetails.tsx and PatientInfoCard.tsx (link, link, link)
  • Cast consultationData as ConsultationModel to avoid type errors in ConsultationDetails.tsx (link)
  • Change the conditions for rendering and disabling the discharge button in ConsultationDetails.tsx to check the consultation's discharge date instead of the patient's active status (link, link)
  • Change the conditions for showing the bed dialog title, passing the discharged prop to the Beds component, showing the discharged from CARE badge, showing the discharge summary and date, and enabling the edit consultation details and log update buttons in PatientInfoCard.tsx to check the consultation's discharge date instead of the patient's active status (link, link, link, link, link, link, link)

@vercel
Copy link

vercel bot commented Apr 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 4:32am

@netlify
Copy link

netlify bot commented Apr 24, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b78ce34
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6446061fbf5b90000888e895
😎 Deploy Preview https://deploy-preview-5379--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@khavinshankar khavinshankar marked this pull request as ready for review April 24, 2023 04:31
@khavinshankar khavinshankar requested a review from a team April 24, 2023 04:31
@khavinshankar khavinshankar requested a review from a team as a code owner April 24, 2023 04:31
@khavinshankar khavinshankar requested a review from bodhish April 24, 2023 04:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Apr 24, 2023
@nihal467
Copy link
Member

LGTM

@gigincg gigincg merged commit 33b2530 into develop Apr 26, 2023
@github-actions
Copy link

@khavinshankar We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@sainak sainak deleted the fix#5374 branch January 19, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consultation history is malfunctioning in care
3 participants