Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds RecordMeta component #4653

Merged
merged 16 commits into from
Feb 28, 2023
Merged

Adds RecordMeta component #4653

merged 16 commits into from
Feb 28, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jan 21, 2023 •
edited
Loading

Proposed Changes

image

image

image

image

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team January 21, 2023 11:51
@rithviknishad rithviknishad requested a review from a team as a code owner January 21, 2023 11:51
@rithviknishad rithviknishad requested a review from gigincg January 21, 2023 11:51
@vercel
Copy link

vercel bot commented Jan 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 28, 2023 at 3:21AM (UTC)

@netlify
Copy link

netlify bot commented Jan 21, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f7bafaa
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63fd7293475e940008f84ac7
😎 Deploy Preview https://deploy-preview-4653--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added cypress failed pull request with cypress test failure merge conflict pull requests with merge conflict labels Jan 21, 2023
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Jan 23, 2023
@rithviknishad rithviknishad added work-in-progress and removed needs testing cypress failed pull request with cypress test failure labels Jan 24, 2023
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 25, 2023
@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Feb 8, 2023
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Feb 8, 2023
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Feb 8, 2023
@rithviknishad rithviknishad added needs testing and removed cypress failed pull request with cypress test failure labels Feb 8, 2023
khavinshankar
khavinshankar reviewed Feb 13, 2023
View reviewed changes
src/CAREUI/display/RelativeTime.tsx Outdated
useEffect(() => {
const timer = setInterval(() => {
setRelativeTime(moment(time).fromNow());
}, 1000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a thought, instead of having this 1000 (1s) why not have it dynamic meaning,
if it is 5 minutes ago, we can have 60 * 1000
if it is hours, it could be 60 * 60 * 1000

@khavinshankar khavinshankar added the question Further information is requested label Feb 13, 2023
@rithviknishad rithviknishad added changes required and removed question Further information is requested labels Feb 13, 2023
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Feb 14, 2023
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad changed the title Adds RelativeTime component Adds RecordMeta component Feb 28, 2023
@rithviknishad rithviknishad added needs testing and removed tested changes required merge conflict pull requests with merge conflict labels Feb 28, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
9.7% 9.7% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Feb 28, 2023
@nihal467
Copy link
Member

LGTM @rithviknishad check the cypress failed

@rithviknishad
Copy link
Member Author

@nihal467 cypress failed to start because of integrity errors in the fixtures.

cc: @khavinshankar @GokulramGHV

@khavinshankar khavinshankar merged commit 350b587 into develop Feb 28, 2023
@rithviknishad rithviknishad deleted the fix-4644 branch July 26, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure good to merge tested
Projects
None yet
Milestone
No milestone
3 participants
@rithviknishad @nihal467 @khavinshankar