-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🛠 Upgrade the colors of tailwind input components + 🛠 Tailwind Consultation Form + 🛠 Tailiwnd discharge patient dialog #4309
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
when someone selecting any symptoms, all the times, if we are seeing this alert statement, feel like it will confuse a normal user a bit, can you take this up in the EOD, and the opinion |
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
make the border green |
https://app.flonnect.com/view/video/nihalcct/63a2bd33f31aaa756efa33bb in the diagnosis, if I select anything starting with 1A, the multi-select are working properly, but when I select something of 3A, then the already selected 1A starting diagnosis are getting unselected |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
LGTM |
Proposed Changes
TextFormField
TextAreaFormField
SelectMenuV2
MultiSelectMenuV2
AutoCompleteAsync
DateInputV2
PhoneInput
TextAreaFormField
's colours have been upgraded to the latest design.InputLabel
andMultilineInputField
to tailwind componentsFieldLabel
andTextFormField
in the Consultation form.Upgrades the colors of tailwind input components and reverted to original grey shades
So far we had 3 shades of gray, and now 1 remains.
Tailwind's gray accessible through
secondary
The CARE gray
The CARE gray that got deviated to match Figma (thinking Figma had correct colors) in 📖 Storybook + 🛠 Tailwind Patient Filters #3744
Made PhoneNumberInput into 1 piece
Before
After
useAsyncOptions
hook helps compose async autocompletes with ease and type-safety :)New Components 🚀
1.
SymptomsSelect
(because ASYMPTOMATIC is listed under symptoms)
Screenshots
2.
PatientCategorySelect
(because it has category-specific colors)
3.
DiagnosisSelect
(because earlier one had issues, and wasn't FormField compliant)
4.
SelectFormField
5.
MultiSelectFormField
(No screenshot for this, as it's not directly used anywhere so far)
6.
AutocompleteV2
(not used anywhere so far, built it now itself because AutocompleteMultiselect was built parallely)
7.
AutocompleteMultiSelectV2
8.
AutocompleteMultiSelectFormField
(Same usage and as the
DiagnosisSelect
mentioned above)@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Screenshots
Merge Checklist