Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Upgrade the colors of tailwind input components + 🛠 Tailwind Consultation Form + 🛠 Tailiwnd discharge patient dialog #4309

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Dec 14, 2022

Proposed Changes

Upgrades the colors of tailwind input components and reverted to original grey shades

image

So far we had 3 shades of gray, and now 1 remains.

  1. Tailwind's gray accessible through secondary
    image

  2. The CARE gray
    image

  3. The CARE gray that got deviated to match Figma (thinking Figma had correct colors) in 📖 Storybook + 🛠 Tailwind Patient Filters #3744
    image

Made PhoneNumberInput into 1 piece

Before

image

After

image

useAsyncOptions hook helps compose async autocompletes with ease and type-safety :)

image

New Components 🚀

1. SymptomsSelect

(because ASYMPTOMATIC is listed under symptoms)

image

image

Screenshots

image

image

image

2. PatientCategorySelect

(because it has category-specific colors)

image

image

image


3. DiagnosisSelect

(because earlier one had issues, and wasn't FormField compliant)

image

image

image

4. SelectFormField

{/* A FormField compliant component of SelectMenuV2 */}
<SelectFormField
  required
  label="Decision after consultation"
  {...selectField("suggestion")}
  options={CONSULTATION_SUGGESTION}
/>

image


5. MultiSelectFormField

{/* A FormField compliant component of MultiSelectMenuV2 */}
<MultiSelectFormField
  required
  label="Decision after consultation"
  {...selectField("suggestion")}
  options={CONSULTATION_SUGGESTION}
/>

(No screenshot for this, as it's not directly used anywhere so far)


6. AutocompleteV2

(not used anywhere so far, built it now itself because AutocompleteMultiselect was built parallely)


7. AutocompleteMultiSelectV2


8. AutocompleteMultiSelectFormField

(Same usage and as the DiagnosisSelect mentioned above)

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Screenshots

image

image

image

image

image

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team December 14, 2022 10:53
@rithviknishad rithviknishad requested a review from a team as a code owner December 14, 2022 10:53
@vercel
Copy link

vercel bot commented Dec 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 21, 2022 at 4:27PM (UTC)

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature labels Dec 14, 2022
@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 771e215
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63a33392354da100099b7351
😎 Deploy Preview https://deploy-preview-4309--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Dec 15, 2022
@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Dec 21, 2022
@nihal467
Copy link
Member

nihal467 commented Dec 21, 2022

@rithviknishad
image

when someone selecting any symptoms, all the times, if we are seeing this alert statement, feel like it will confuse a normal user a bit, can you take this up in the EOD, and the opinion

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 21, 2022
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Dec 21, 2022
@nihal467
Copy link
Member

@rithviknishad
image

make the border green

@nihal467
Copy link
Member

nihal467 commented Dec 21, 2022

@rithviknishad

https://app.flonnect.com/view/video/nihalcct/63a2bd33f31aaa756efa33bb

in the diagnosis, if I select anything starting with 1A, the multi-select are working properly, but when I select something of 3A, then the already selected 1A starting diagnosis are getting unselected

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 41 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 397a2ce into ohcnetwork:develop Dec 22, 2022
@rithviknishad rithviknishad mentioned this pull request Feb 7, 2023
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Major Code Change This Tag represent PR, which will be causing major Code change in the platform P1 breaking issue or vital feature redesign tested
Projects
None yet
3 participants