Rebuild questionnaireForm updateHandler #10115

amjithtitus09 · 2025-01-23T08:19:36Z

Issue: Race condition in questionnaireForm setState for Questionnaires with multiple Questions

Fix: Rebuild questionnaireForm updateHandler to receive values instead of entire QuestionnaireResponse

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

…entire QuestionnaireResponse

coderabbitai · 2025-01-23T08:19:43Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

nihal467 · 2025-01-23T09:51:21Z

Bug

When we try to edit fields such as dosage or any other details of medicines that are already present, the submission works, and we receive a notification. However, the preview continues to display the old data. Additionally, if you reopen the edit prescription form, the old data is still visible.

when we remove an already active symptoms, the status is not modified in the preview section.

Note: In the questionnaire form, it still shows as "already marked an error" in the dropdown.

When we remove an allergy or mark it as inactive, both are treated as inactive in the frontend preview. I believe removing an allergy means completely deleting it. Can you confirm this behavior?

Similar Behavior is observed for diagnosis

Non-PR Related

keep the date reflection in the preview card in DD/MM/YYYY format
Similar change in the medication request structured questionnaire

… hide removed items from overview

cloudflare-workers-and-pages · 2025-01-23T12:16:41Z

Deploying care-fe with Cloudflare Pages

Latest commit:	`72e81ce`
Status:	✅ Deploy successful!
Preview URL:	https://86503dc8.care-fe.pages.dev
Branch Preview URL:	https://questionnaire-update-rebuild.care-fe.pages.dev

View logs

amjithtitus09 · 2025-01-23T12:24:24Z

@nihal467

Medicine Request update seems to be a BE issue. The fix is being pushed.
Removing existing items would mark them as 'Entered in error' in BE along with graying out and disabling the row in FE to prevent further changes.
The removed rows would now be hidden by default in the Overview section. Clicking the "view all" would reveal them grayed out.
Fixed the date picker format issue in the form. The format displayed in the Overview is dd/mm/yyyy for me.

nihal467 · 2025-01-23T22:20:34Z

When we remove an allergy, even though it is marked as 'entered in error' in the editor, it still appears as active under status (but greyed out) in the preview. This doesn’t feel like good UX.

@amjithtitus09 its happening across the items

…are_fe into questionnaire-update-rebuild

amjithtitus09 · 2025-01-24T06:43:59Z

@nihal467 Pushed these

Added missing status columns
Show entered in error items at the bottom of the list
"Entered in error" in red

nihal467 · 2025-01-24T10:01:48Z

LGTM, Except Medication request, and statement modification (Work in progress)

…are_fe into questionnaire-update-rebuild

nihal467 · 2025-01-25T08:51:08Z

fix the padding issue for the structured question previews, rest LGTM

…are_fe into questionnaire-update-rebuild

github-actions · 2025-01-25T09:25:10Z

👋 Hi, @amjithtitus09,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

…are_fe into questionnaire-update-rebuild

amjithtitus09 · 2025-01-25T09:54:45Z

@nihal467

nihal467 · 2025-01-25T10:39:15Z

LGTM, finally its done :)

github-actions · 2025-01-25T14:11:11Z

@amjithtitus09 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Rebuild questionnaireForm updateHandler to receive values instead of …

a3d2371

…entire QuestionnaireResponse

amjithtitus09 requested a review from a team as a code owner January 23, 2025 08:19

nihal467 added the test failed label Jan 23, 2025

Disable row when existing items are removed, date picker format, temp…

f22a067

… hide removed items from overview

amjithtitus09 added 2 commits January 24, 2025 11:57

Entered in error UI changes

e59b0cd

Merge branch 'structured_prefills' of https://github.com/ohcnetwork/c…

ac45de1

…are_fe into questionnaire-update-rebuild

github-actions bot added needs-triage question Further information is requested labels Jan 24, 2025

amjithtitus09 added 2 commits January 24, 2025 12:37

MedicationStatement | Add missing encounter field

5c2c484

Removed console log

9f130a7

amjithtitus09 added 2 commits January 24, 2025 18:23

Update only selected fields

5d735e2

Merge branch 'structured_prefills' of https://github.com/ohcnetwork/c…

fd5b993

…are_fe into questionnaire-update-rebuild

Merge branch 'structured_prefills' of https://github.com/ohcnetwork/c…

7ceecf9

…are_fe into questionnaire-update-rebuild

github-actions bot added the merge conflict pull requests with merge conflict label Jan 25, 2025

amjithtitus09 added 2 commits January 25, 2025 15:02

Merge branch 'structured_prefills' of https://github.com/ohcnetwork/c…

747b325

…are_fe into questionnaire-update-rebuild

Fixed padding for allergy, symptom, diagnosis tables

72e81ce

amjithtitus09 removed the merge conflict pull requests with merge conflict label Jan 25, 2025

nihal467 removed question Further information is requested test failed labels Jan 25, 2025

nihal467 added needs review tested and removed needs-triage labels Jan 25, 2025

amjithtitus09 merged commit cbfa87a into structured_prefills Jan 25, 2025
5 checks passed

amjithtitus09 deleted the questionnaire-update-rebuild branch January 25, 2025 14:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebuild questionnaireForm updateHandler #10115

Rebuild questionnaireForm updateHandler #10115

amjithtitus09 commented Jan 23, 2025

coderabbitai bot commented Jan 23, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

nihal467 commented Jan 23, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 23, 2025 •

edited

Loading

amjithtitus09 commented Jan 23, 2025

nihal467 commented Jan 23, 2025 •

edited

Loading

amjithtitus09 commented Jan 24, 2025

nihal467 commented Jan 24, 2025

nihal467 commented Jan 25, 2025 •

edited

Loading

github-actions bot commented Jan 25, 2025

amjithtitus09 commented Jan 25, 2025

nihal467 commented Jan 25, 2025 •

edited

Loading

github-actions bot commented Jan 25, 2025

Rebuild questionnaireForm updateHandler #10115

Rebuild questionnaireForm updateHandler #10115

Conversation

amjithtitus09 commented Jan 23, 2025

Merge Checklist

coderabbitai bot commented Jan 23, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

nihal467 commented Jan 23, 2025 • edited Loading

Bug

Non-PR Related

cloudflare-workers-and-pages bot commented Jan 23, 2025 • edited Loading

Deploying care-fe with Cloudflare Pages

amjithtitus09 commented Jan 23, 2025

nihal467 commented Jan 23, 2025 • edited Loading

amjithtitus09 commented Jan 24, 2025

nihal467 commented Jan 24, 2025

nihal467 commented Jan 25, 2025 • edited Loading

github-actions bot commented Jan 25, 2025

amjithtitus09 commented Jan 25, 2025

nihal467 commented Jan 25, 2025 • edited Loading

github-actions bot commented Jan 25, 2025

CodeRabbit Configuration File (`.coderabbit.yaml`)

nihal467 commented Jan 23, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 23, 2025 •

edited

Loading

nihal467 commented Jan 23, 2025 •

edited

Loading

nihal467 commented Jan 25, 2025 •

edited

Loading

nihal467 commented Jan 25, 2025 •

edited

Loading