Fixed text overflow in search results to prevent UI distortion #10055

i0am0arunava · 2025-01-19T16:13:46Z

Proposed Changes

Fixes Text Overflow in Search Results Causes UI Distortion #10036

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

Style
- Enhanced readability of messages when no organizations are found by simplifying the displayed text.
- Standardized capitalization for the "No Organizations Found" message in the locale file.
Bug Fixes
- Removed dynamic search query from "no organizations found" messages for clarity.

from develop

merge

merge fromdevelop branch

partially revert c9343d5 to fix investigation issues (ohcnetwork#9026)

rgdf

fghfh

i

coderabbitai · 2025-01-19T16:13:54Z

Walkthrough

The pull request modifies the FacilityOrganizationView and OrganizationView components to simplify the messages displayed when no organizations are found. The dynamic inclusion of the search query in these messages has been removed, resulting in static messages. Additionally, the public/locale/en.json file was updated to change the capitalization of a specific string and to add a new string for better clarity when no organizations match a search query.

Changes

File	Change Summary
`src/pages/FacilityOrganization/FacilityOrganizationView.tsx`, `src/pages/Organization/OrganizationView.tsx`	Updated no-organization messages to static text.
`public/locale/en.json`	Changed capitalization of `"no_organizations_found"` string from `"No organizations found"` to `"No Organizations Found"`; added `"no_organizations_found_matching"` string.

Assessment against linked issues

Objective	Addressed	Explanation
Prevent Text Overflow [#10036]	❌	The changes do not address the overflow issue related to long search queries.

Possibly related PRs

Updated UX for ValueSetSelect component #9685: This PR modifies the public/locale/en.json file to update the string for "searching" and adds localization support, which is relevant to the changes in the main PR that also involve localization updates.
Adds query.debounced and updated queries that require debouncing #9865: This PR introduces a query.debounced function and updates queries to use it, which aligns with the changes in the main PR where the query execution method is modified to improve performance.
Care Loading icon in organization and facility users #9723: This PR enhances the FacilityOrganizationView component by improving loading state presentation and internationalization, which is directly related to the changes made in the main PR regarding the same component.

Suggested labels

good to merge, needs review

Suggested reviewers

rithviknishad
Jacobjeevan

Poem

🐰 In the land of code where rabbits play,
Messages now clearer, come what may.
No more queries to muddle the sight,
Just simple words, all polished and bright!
Hop along, let the UI shine,
With every change, our work's divine! 🎉

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 31a80cb and f7f8a71.

📒 Files selected for processing (2)

src/pages/FacilityOrganization/FacilityOrganizationView.tsx (1 hunks)
src/pages/Organization/OrganizationView.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

src/pages/FacilityOrganization/FacilityOrganizationView.tsx
src/pages/Organization/OrganizationView.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-19T16:14:06Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`d2f48b8`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/678e13e2013ae60008f5d54d
😎 Deploy Preview	https://deploy-preview-10055--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

i0am0arunava · 2025-01-19T16:18:23Z

@rithviknishad ,fixed text overflow
Before :

After :

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/pages/FacilityOrganization/FacilityOrganizationView.tsx (1)
137-137: LGTM! Consider adding overflow-wrap for better word breaking.

The addition of max-w-full break-words effectively prevents text overflow. However, for even better handling of long words (especially URLs or long strings without spaces), consider adding overflow-wrap-anywhere.
-                  <CardContent className="p-6 text-center text-gray-500 max-w-full break-words">
+                  <CardContent className="p-6 text-center text-gray-500 max-w-full break-words overflow-wrap-anywhere">

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 206ee47 and 0145ffb.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (2)

src/pages/FacilityOrganization/FacilityOrganizationView.tsx (1 hunks)
src/pages/Organization/OrganizationView.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

src/pages/Organization/OrganizationView.tsx

🔇 Additional comments (1)

src/pages/FacilityOrganization/FacilityOrganizationView.tsx (1)

137-137: Verify consistent styling across organization views.

The AI summary mentions similar changes in OrganizationView.tsx. Let's verify the consistency of these styling changes.

✅ Verification successful

Styling is consistent across organization views

The styling pattern p-6 text-center text-gray-500 max-w-full break-words is consistently applied in both FacilityOrganizationView.tsx and OrganizationView.tsx. Other organization-related components use a similar base style for their "no results" states.
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Search for CardContent styling in organization view components
rg --type typescript 'CardContent.*className.*text-center.*text-gray-500' src/
Length of output: 115

Script:
#!/bin/bash
# Search for CardContent styling in .ts and .tsx files
rg "CardContent.*className" --type-add 'ts:*.{ts,tsx}' --type ts -A 2 src/
Length of output: 13295

rithviknishad

#10036 (comment)

rithviknishad · 2025-01-19T16:38:05Z

I don't see much value in showing that search text in view again... Let's keep it simple like how we show in other places. "No organisations found"

public/locale/en.json

rithviknishad · 2025-01-19T17:26:09Z

package-lock.json

discard the lockfile changes

src/pages/FacilityOrganization/FacilityOrganizationView.tsx

src/pages/Organization/OrganizationView.tsx

rithviknishad · 2025-01-19T17:27:01Z

other than these, lgtm

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

github-actions · 2025-01-20T09:15:09Z

@i0am0arunava Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

i0am0arunava added 8 commits November 6, 2024 13:48

Merge pull request #1 from ohcnetwork/develop

ce241c3

from develop

Merge pull request #2 from ohcnetwork/develop

80e48d6

merge

Merge pull request #3 from ohcnetwork/develop

3f5fcd3

merge fromdevelop branch

Merge pull request #4 from ohcnetwork/develop

4cc9892

partially revert c9343d5 to fix investigation issues (ohcnetwork#9026)

Merge pull request #5 from ohcnetwork/develop

9a2ac6f

rgdf

Merge pull request #6 from ohcnetwork/develop

2323a97

fghfh

Merge pull request #7 from ohcnetwork/develop

1ccd6ac

i

Text Overflow in Search Results Causes UI Distortion

0145ffb

i0am0arunava requested a review from a team as a code owner January 19, 2025 16:13

coderabbitai bot reviewed Jan 19, 2025

View reviewed changes

rithviknishad requested changes Jan 19, 2025

View reviewed changes

rithviknishad added the changes required label Jan 19, 2025

requested changes are done

6be7c01

rithviknishad requested changes Jan 19, 2025

View reviewed changes

i0am0arunava and others added 4 commits January 20, 2025 00:32

Update public/locale/en.json

31a80cb

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

Update src/pages/Organization/OrganizationView.tsx

60a7e68

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

Update src/pages/FacilityOrganization/FacilityOrganizationView.tsx

f7f8a71

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>

discard lockfile changes

d2f48b8

rithviknishad approved these changes Jan 20, 2025

View reviewed changes

rithviknishad merged commit 02a0558 into ohcnetwork:develop Jan 20, 2025
11 of 12 checks passed

This was referenced Jan 21, 2025

Fix: FacilityData not populating on Edit #10077

Merged

Feat: Display total no. of entities with heading in Organization #10092

Open

Fix: Facility Organization Dropdown #10104

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed text overflow in search results to prevent UI distortion #10055

Fixed text overflow in search results to prevent UI distortion #10055

i0am0arunava commented Jan 19, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 19, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 19, 2025 •

edited

Loading

i0am0arunava commented Jan 19, 2025 •

edited

Loading

coderabbitai bot left a comment

rithviknishad left a comment

rithviknishad commented Jan 19, 2025

rithviknishad Jan 19, 2025

rithviknishad commented Jan 19, 2025

github-actions bot commented Jan 20, 2025

Fixed text overflow in search results to prevent UI distortion #10055

Fixed text overflow in search results to prevent UI distortion #10055

Conversation

i0am0arunava commented Jan 19, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Jan 19, 2025 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 19, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

i0am0arunava commented Jan 19, 2025 • edited Loading

coderabbitai bot left a comment

Choose a reason for hiding this comment

rithviknishad left a comment

Choose a reason for hiding this comment

rithviknishad commented Jan 19, 2025

rithviknishad Jan 19, 2025

Choose a reason for hiding this comment

rithviknishad commented Jan 19, 2025

github-actions bot commented Jan 20, 2025

i0am0arunava commented Jan 19, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 19, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 19, 2025 •

edited

Loading

i0am0arunava commented Jan 19, 2025 •

edited

Loading