flaky test in resource tab test

ohcnetwork · Dec 15, 2024 · cfb743a · cfb743a
1 parent 4f05216
commit cfb743a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/cypress/e2e/resource_spec/ResourcesHomepage.cy.ts b/cypress/e2e/resource_spec/ResourcesHomepage.cy.ts
@@ -20,14 +20,15 @@ describe("Resource Page", () => {
   beforeEach(() => {
     cy.restoreLocalStorage();
     cy.clearLocalStorage(/filters--.+/);
-    cy.awaitUrl("/resource");
   });
 
   it("Checks if all download button works", () => {
+    resourcePage.navigationToResourcePage();
     resourcePage.verifyDownloadButtonWorks();
   });
 
   it("Switch between active/completed", () => {
+    resourcePage.navigationToResourcePage();
     resourcePage.spyResourceApi();
     resourcePage.clickCompletedResources();
     resourcePage.verifyCompletedResources();
@@ -37,6 +38,7 @@ describe("Resource Page", () => {
   });
 
   it("Switch between list view and board view", () => {
+    resourcePage.navigationToResourcePage();
     resourcePage.clickListViewButton();
     resourcePage.clickBoardViewButton();
   });
@@ -68,7 +70,7 @@ describe("Resource Page", () => {
   });
 
   it("Update the status of resource", () => {
-    cy.visit(createdResource);
+    cy.awaitUrl(createdResource);
     resourcePage.clickUpdateStatus();
     resourcePage.updateStatus("APPROVED");
     resourcePage.clickSubmitButton();
@@ -78,7 +80,7 @@ describe("Resource Page", () => {
   });
 
   it("Post comment for a resource", () => {
-    cy.visit(createdResource);
+    cy.awaitUrl(createdResource);
     resourcePage.addCommentForResource("Test comment");
     resourcePage.clickPostCommentButton();
     resourcePage.verifySuccessNotification("Comment added successfully");

diff --git a/cypress/pageobject/Facility/FacilityHome.ts b/cypress/pageobject/Facility/FacilityHome.ts
@@ -9,7 +9,7 @@ class FacilityHome {
   }
 
   navigateToFacilityHomepage() {
-    cy.visit("/facility");
+    cy.awaitUrl("/facility");
   }
 
   assertFacilityInCard(facilityName: string) {

diff --git a/cypress/pageobject/Resource/ResourcePage.ts b/cypress/pageobject/Resource/ResourcePage.ts
@@ -28,6 +28,10 @@ class ResourcePage {
     cy.contains("button", "Active").click();
   }
 
+  navigationToResourcePage() {
+    cy.awaitUrl("/resource");
+  }
+
   verifyActiveResources() {
     cy.wait("@resource").its("response.statusCode").should("eq", 200);
     cy.contains("button", "Active").should("have.class", "text-white");