Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lockfile #854

Merged
merged 5 commits into from
Apr 26, 2021
Merged

Update lockfile #854

merged 5 commits into from
Apr 26, 2021

Conversation

harens
Copy link
Contributor

@harens harens commented Apr 22, 2021

Hopefully closes #853.

Update the lockfile to match cargo.toml.

@ariasuni
Copy link
Collaborator

Please update Rust’s version to 1.45.0 in .travis.yml and README.md, like I did in #857. You updated the git2 version, and now it needs at least Rust 1.45.0.

@harens
Copy link
Contributor Author

harens commented Apr 26, 2021

Thank you for your response @ariasuni (and for your work on this project).

I left it as a separate commit so as not to get too much in the way of #857, and so that it's possible to only cherry pick my original commit if desired.

@ariasuni
Copy link
Collaborator

Don’t worry, I’ll rebase my pull request after I merge this. I’m just waiting for the CI checks to finish.

Copy link
Collaborator

@ariasuni ariasuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s depend on Rust 1.45.2 since it the latest 1.45.x and it fixes bugs. Also, the link to the Rust blog was incorrect.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@ariasuni ariasuni merged commit 90b9775 into ogham:master Apr 26, 2021
@ariasuni
Copy link
Collaborator

Aaaand it’s done! \o/ Also:

Thank you for your response @ariasuni (and for your work on this project).

I’m glad my work is useful and appreciated :)

@harens
Copy link
Contributor Author

harens commented Apr 27, 2021

Thank you for merging! 🎉 (and for correcting my mistakes...)

@harens harens deleted the lockfile branch April 27, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo lockfile outdated
2 participants