load statistics from youtube when links are pasted to channel #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Aug 9, 2017
There was a problem hiding this comment.
Per #63 (comment), we should only respond to explicit triggers, not just to random links.
ecmabot.js
Outdated
| @@ -18,6 +18,7 @@ var JSBot = function(profile) { | |||
| this.factoids = new FactoidServer(path.join(__dirname, "ecmabot-factoids.json")); | |||
| this.caniuse_server = new CanIUseServer; | |||
| this.executeRegex = /^((?:sm?|v8|js?|b|n|>>?|>>>>|\|)>)([^>].*)+/; | |||
| this.youtubeRegex = /https?:\/\/www.youtube.com\/watch\?v=(\w+)/; | |||
There was a problem hiding this comment.
I believe the best use for an "explicit trigger" would then be a command like !yt to make it go fetch and paste data after somebody else has already pasted a link. Then it would only occur if at least one user is interested.
youtu.be links won't be a problem, but, maybe the googleapi auth key will?
There was a problem hiding this comment.
i mainly meant the regex :-) you can extract the video ID from both links if needed.
|
I think it's something like this. But now you might want to have a good look on those regexes and stuff it does there... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#63