Refactored locking implementation. #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdbergh
force-pushed
the
openlock
branch
16 times, most recently
from
eee5cec
to
9a7e0cc
Compare
|
Rebased after #2068 |
We have refactored the locking implementation in the worker as a self-contained package "packages/openlock". The package is also available on github https://github.com/vdbergh/openlock and on PyPi https://pypi.org/search/?q=openlock This PR cleans up the worker code considerably.
ppigazzini
added
enhancement
worker update
|
https://stackoverflow.com/questions/48571212/why-is-sys-exit-causing-a-traceback *** Another worker (with PID=3424) is already running in this directory ***
Traceback (most recent call last):
File "C:\Users\WDAGUtilityAccount\Desktop\worker\worker.py", line 1625, in <module>
sys.exit(worker())
SystemExit: 1 |
|
Is there any particular reason why on Windows Python is invoked as |
|
The worker is started with a double click on a launcher cmd, with the -i the user views the traceback in case of error, otherwise the windows simply close. |
ppigazzini
approved these changes
Jul 5, 2024
|
Triggered the worker updated, thank you @vdbergh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have refactored the locking implementation in the worker as a self-contained package "packages/openlock". The package is also available on github
https://github.com/vdbergh/openlock
and on PyPi
https://pypi.org/search/?q=openlock
This PR cleans up the worker code considerably.