Remove compensation factor to adjust extra time according to time control #5730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-format 18 needs to be run on this PR. (execution 12429824112 / attempt 1) |
|
I believe that VLTC testing is needed as the original patch did not pass LTC |
|
maybe it would be beneficial to add some comments there to indicate the non-linear scaling, similar to what we have in SE and LMR code |
|
@xu-shawn Yes, I was also thinking so, but unfortunately, lately, disservin is ignoring the PRs related to comments. So I don't know. I guess will try later, lets' see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the compensation factor to adjust extra time according to time control, as it's no longer bringing benefit.
P.s: When introduced it was also tested at 180+1.8, so let me know if an additional test at this TC is needed.
Passed STC:
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 102752 W: 26712 L: 26566 D: 49474
Ptnml(0-2): 395, 11713, 26950, 11987, 331
https://tests.stockfishchess.org/tests/view/67630eb286d5ee47d9543420
Passed LTC:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 67284 W: 17133 L: 16962 D: 33189
Ptnml(0-2): 24, 7133, 19184, 7250, 51
https://tests.stockfishchess.org/tests/view/6763fe0686d5ee47d9543d2b
bench: 934447