Avoid passing an emptry string as the tag_regex parameter to setuptools_scm.get_version
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
changed the title
tag-pattern instead of empty stringtag_regex parameter of setuptools_scm.get_version
edgarrmondragon
changed the title
tag_regex parameter of setuptools_scm.get_versiontag_regex parameter to setuptools_scm.get_version
edgarrmondragon
force-pushed
the
tag-pattern-setuptools-scm-default-value
branch
2 times, most recently
from
d9e5a1e
to
8971d8a
Compare
…tools_scm.get_version` Closes ofek#67
edgarrmondragon
force-pushed
the
tag-pattern-setuptools-scm-default-value
branch
from
8971d8a
to
644b478
Compare
edgarrmondragon
commented
Jul 1, 2024
| @@ -86,7 +86,7 @@ def create_project(directory, metadata, *, setup_vcs=True, nested=False): | |||
| git('config', '--local', 'user.email', 'foo@bar.baz') | |||
| git('add', '.') | |||
| git('commit', '-m', 'test') | |||
| git('tag', '1.2.3') | |||
| git('tag', '1.2.3', '-m', 'test') | |||
There was a problem hiding this comment.
The old code was causing tests to hang for me locally, so let me know if this is ok or I should revert it.
There was a problem hiding this comment.
Let's log a follow up to investigate
|
@ofek should I apply the necessary changes for tool changes in a separate mr or can this get in whole? |
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
|
it's fine to do it here I think |
| @@ -53,7 +53,9 @@ def construct_setuptools_scm_config(self): | |||
| config = deepcopy(self.config_raw_options) | |||
| config.setdefault('root', self.root) | |||
|
|
|||
| config.setdefault('tag_regex', self.config_tag_pattern) | |||
| # Only set for non-empty strings | |||
| if self.config_tag_pattern: | |||
There was a problem hiding this comment.
i believe instead of setdefault the normal setitem operation should be used
There was a problem hiding this comment.
80a8191 I also added a test that goes into the if block
RonnyPfannschmidt
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67