STY: Fix style issues #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes mypy error:
tests/conftest.py:18:5: error: Incompatible redefinition (redefinition with
type "Callable[[Any, Any, Any, VarArg(Any), KwArg(Any)], Any]", original type
"_RmtreeType") [misc]
def rmtree(path, ignore_errors=False, onerror=None, *args, **kwds)...
^
tests/conftest.py:18:5: note: "function" is missing following "_RmtreeType" protocol member:
tests/conftest.py:18:5: note: avoids_symlink_attacks
effigies
force-pushed
the
sty/fix-style-issues
branch
2 times, most recently
from
5618682
to
7dc224d
Compare
effigies
force-pushed
the
sty/fix-style-issues
branch
from
7dc224d
to
32c64b4
Compare
|
@ofek All green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unclear why F401 needed to be "unfixable", so I removed it. The specific violation of FBT002 is unavoidable for compatibility, but it also doesn't seem like a useful check, so I ignored it generally instead of with a
#noqa.Closes #54.