FIX: Only pass template to setuptools_scm.dump_version() if defined #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems more correct to return the actual value (
None
for absent) than a fake value. This will allow us to distinguish the casetemplate = ""
(which setuptools_scm could reasonably treat as an error) from it missing.This patch uses a
sentinel
object to allow the result caching to work withNone
values. Once Python 3.7 is dropped, much of this machinery can be replaced withfunctools.cached_property
.Fixes #49.