Use MediaWiki coding standards #13
Merged
+462
−689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add normal MediaWiki extension phpcs configuration, and fix linting errors. Bug: GH #9
|
Hey thank you for this pull request. I don't have the cycles to properly review this, and I'm out of touch with what is going in mediawiki these days. Nor do I have a way to test this PR. If you'd like to take over the project and repoint the mediawiki Realnames page to a fork you make, that would be acceptable to me and I can retire this one. As such, I'm going to accept this PR as-is. |
|
Terrific, thank you! I'll have a think about adopting it. If I do, I'd probably shift to Gerrit so it could take advantage of being more visible for updates and things like the codesearch tool. I'll let you know though. :-) |
|
That would be fine with me too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add normal MediaWiki extension phpcs configuration, and fix linting
errors.
Bug: GH #9