Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize text of ParticipantObjectQuery in DICOM audit parser #432

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

qligier
Copy link
Contributor

@qligier qligier commented Nov 8, 2023

In DICOM audit messages, ParticipantObjectQuery is a xsd:base64Binary, which collapses whitespaces. When reading it, we should normalize the value before trying to base64-decode it.

Currently, it fails if the XML is indented:

<ParticipantObjectQuery>
    VVRGLTg=
</ParticipantObjectQuery>

We can use getChildTextTrim instead of getChildTextNormalize, because whitespaces are not allowed inside the base64 content, so there's no point in normalizing them.

@unixoid unixoid self-assigned this Nov 8, 2023
@unixoid unixoid merged commit d1642a1 into oehf:master Nov 8, 2023
2 of 4 checks passed
@unixoid
Copy link
Member

unixoid commented Nov 8, 2023

Thank you @qligier !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants