fix windows clang-cl build error #399 #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workaround the build error: constexpr variable 'strnlen' must be initialized by a constant expression. The reason for the error is that strnlen() seems to be incompatible with constexpr in clang-cl compilation.
tetsuh
force-pushed
the
fix_clangcl_build
branch
from
ca6a3f8 to
401608a
Compare
|
Thanks for the PR : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Windows clang-cl build error: "constexpr variable 'strnlen' must be initialized by a constant expression. "
Unfortunately the strnlen() seems incompatible with constexpr in clang-cl compile.
But in the case of this case, MSVC/clang-cl can use the strnlen_s() function anyway.
This changes should only affects the Windows MSVC/clang-cl build.
descrived in #399