Skip to content

Commit

Permalink
update benchmarks and changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
odygrd committed Mar 20, 2024
1 parent bb64732 commit b51aed1
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 9 deletions.
2 changes: 0 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@
enough space to push the message, which could make it less accurate. Additionally, in the case of a blocking queue,
the timestamp could be later in time. Now, the timestamp is taken and stored right after the log statement is issued,
before checking for the queue size.
- The throughput of the backend worker thread has been improved by approximately 3%. This enhancement is reflected in
the new throughput value of 4.10 million msgs/sec, compared to the previous throughput of 3.98 million msgs/sec.

## v3.7.0

Expand Down
4 changes: 2 additions & 2 deletions benchmarks/backend_throughput/quill_backend_throughput.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ int main()
quill::detail::set_cpu_affinity(0);

quill::Config cfg;
cfg.backend_thread_yield = false;
cfg.backend_thread_cpu_affinity = 1;

cfg.backend_thread_cpu_affinity = 5;

quill::configure(cfg);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ int main()
quill::detail::set_cpu_affinity(0);

quill::Config cfg;
cfg.backend_thread_yield = false;
cfg.backend_thread_cpu_affinity = 1;

cfg.backend_thread_cpu_affinity = 5;
cfg.backend_thread_use_transit_buffer = false;

quill::configure(cfg);
Expand All @@ -31,7 +31,8 @@ int main()
cfg.set_open_mode('w');
return cfg;
}());
file_handler->set_pattern("%(time) [%(thread)] %(short_source_location) %(log_level) %(message)");
file_handler->set_pattern(
"%(time) [%(thread_id)] %(short_source_location) %(log_level) %(message)");
quill::Logger* logger = quill::create_logger("bench_logger", std::move(file_handler));
quill::preallocate();

Expand Down
4 changes: 3 additions & 1 deletion benchmarks/hot_path_latency/quill_hot_path_rdtsc_clock.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ void quill_benchmark(std::vector<int32_t> const& thread_count_array,

/** - Setup Quill **/
quill::Config cfg;
cfg.backend_thread_yield = false;

cfg.backend_thread_cpu_affinity = 5;
// cfg.enable_huge_pages_hot_path = true; // enable huge pages

quill::configure(cfg);

// Start the logging backend thread
Expand Down
3 changes: 2 additions & 1 deletion benchmarks/hot_path_latency/quill_hot_path_system_clock.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@ void quill_benchmark(std::vector<int32_t> const& thread_count_array,

/** - Setup Quill **/
quill::Config cfg;
cfg.backend_thread_yield = false;

cfg.backend_thread_cpu_affinity = 5;
cfg.default_timestamp_clock_type = quill::TimestampClockType::System;
// cfg.enable_huge_pages_hot_path = true; // enable huge pages

quill::configure(cfg);

Expand Down

0 comments on commit b51aed1

Please sign in to comment.