disable fmt::join

odygrd · Nov 2, 2023 · 4cc4dae · 4cc4dae
1 parent a3dbd03
commit 4cc4dae
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -89,11 +89,15 @@
   ```
 
 - Minor improvements in the bounded queue and throughput. ([#362](https://github.com/odygrd/quill/pull/362))
-  
+
   Previous: 2.21 million msgs/sec average, total time elapsed: 1809 ms for 4000000 log messages.
-  
+
   New:      2.24 million msgs/sec average, total time elapsed: 1787 ms for 4000000 log messages.
 
+- Disable `fmt::join(data, "")` at compile time. ([#356](https://github.com/odygrd/quill/issues/356))
+- Add guards for redefined preprocessor variables.
+- Fix `uint64_t` to `time_t` implicit conversion error in Clang 18.
+
 ## v3.3.1
 
 - Fixed `RotatingFileHandler` to prevent accidental removal of non-log files when using open mode `w`

diff --git a/quill/include/quill/detail/misc/TypeTraitsCopyable.h b/quill/include/quill/detail/misc/TypeTraitsCopyable.h
@@ -12,6 +12,8 @@
 #include <type_traits>
 #include <utility>
 
+#include "quill/Fmt.h"
+
 /**
  * Below are type traits to determine whether an object is marked as copyable.
  * The traits are used to decide about
@@ -332,7 +334,8 @@ struct filter_copyable : std::conjunction<std::disjunction<std::is_arithmetic<T>
                                      is_copyable_tuple<T>,
                                      is_copyable_optional<T>,
                                      is_copyable_container<T>
-                                     >, std::negation<is_reference_wrapper<T>>>
+                                     >, std::negation<is_reference_wrapper<T>>,
+                                        std::negation<std::is_base_of<fmtquill::detail::view, T>>>
 {};
 
 /**