Fix consumer start() hanging after long idle (fixes aio-libs#764)

ods · Jul 12, 2021 · 9288679 · 9288679
1 parent 24a062d
commit 9288679
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGES/764.bugfix b/CHANGES/764.bugfix
@@ -0,0 +1,2 @@
+Fix consumer's `start()` method hanging after being idle for more than
+`max_poll_interval_ms`
diff --git a/aiokafka/consumer/group_coordinator.py b/aiokafka/consumer/group_coordinator.py
@@ -681,7 +681,7 @@ async def ensure_active_group(self, subscription, prev_assignment):
 
         # We will not attempt rejoin if there is no activity on consumer
         idle_time = self._subscription.fetcher_idle_time
-        if idle_time >= self._max_poll_interval:
+        if prev_assignment is not None and idle_time >= self._max_poll_interval:
             await asyncio.sleep(self._retry_backoff_ms / 1000)
             return None
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Fix consumer's `start()` method hanging after being idle for more than
		`max_poll_interval_ms`