[ADD] SFU server #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThanhDodeurOdoo
force-pushed
the
master-discuss-rtc-server2-tso
branch
from
271ee6d to
08f63d2
Compare
ThanhDodeurOdoo
force-pushed
the
master-discuss-rtc-server2-tso
branch
from
08f63d2 to
209af28
Compare
The SFU is a server used to relay streaming between the participants of a call to provide better scalability and performance than the current peer-to-peer connections. [README](https://github.com/odoo/sfu/tree/master-discuss-rtc-server2-tso/) Old PR: odoo/enterprise#45861 Related to: odoo/odoo#132153 task-2765922
ThanhDodeurOdoo
force-pushed
the
master-discuss-rtc-server2-tso
branch
from
209af28 to
0c61202
Compare
seb-odoo
reviewed
Dec 5, 2023
Comment on lines
+9
to
+10
| "node": true, | ||
| "browser": false, |
There was a problem hiding this comment.
isn't node or browser differently true or false (or sometimes both at the same time) depending on the file?
There was a problem hiding this comment.
the overrides below are setting the env with the right values for the few files where it is not (just) node
seb-odoo
reviewed
Dec 5, 2023
seb-odoo
reviewed
Dec 5, 2023
|
|
||
| - GET `/v1/stats`: returns the server statistics in JSON: | ||
| ```json | ||
| [ // one array entry per channel |
There was a problem hiding this comment.
Comment is invalid json, suggestion to use a specific key "_comment" or comment it separately
There was a problem hiding this comment.
fix for both README comments in #2
seb-odoo
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SFU is a server used to relay streaming between the participants of a call to provide better scalability and performance than the current peer-to-peer connections.
README
Old PR: https://github.com/odoo/enterprise/pull/45861
Related to: odoo/odoo#132153
task-2765922