Updates to test skipping and fixtures #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adler-j
changed the title
| @@ -134,31 +150,45 @@ def test_setitem(fn): | |||
| assert x[index] == -index | |||
|
|
|||
|
|
|||
| @pytest.mark.xfail(reason='Expected to fail since inner scaling is not public') | |||
There was a problem hiding this comment.
These xfails have been removed, now we test that the weighting is correct, but assume that the constant weighting is used, should be improved but works for all current test cases.
There was a problem hiding this comment.
Well yeah, it's the only one implemented :-). TODO, but not super high prio
|
This also fixes a bug on master where the skip if no largescale is missing, thus making the tests take a minute instead of 5 seconds. |
| def exponent(request): | ||
| return request.param | ||
|
|
||
|
|
||
| impl_params = [never_skip('numpy'), |
|
Found just one minor thing. Number of tests went up from ~1500 to almost 2000. Good for people who like numbers :-) Looks very good otherwise. |
|
Oh, and 👍 for removing more code than adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some fixes to test skipping etc, the number of tests should now be the same across all platforms and with any combination of optional packages, any non-usable package will properly show as
skippedinstead of staying silent.