Added core_3d_camera_fps.odin example #129

GCodergr · 2025-09-07T14:10:54Z

Added core_3d_camera_fps.odin example which is based on raylib core_3d_camera_fps.c.
The original c example is playable here .

Checklist before submitting:

This example has been added to .github/workflows/check.yml (for automatic testing)
This example compiles cleanly with flags -vet -strict-style -vet-tabs -disallow-do -warnings-as-errors
This example follows the core naming convention: https://github.com/odin-lang/Odin/wiki/Naming-Convention (exception can be made for ports of examples that need to match 1:1 to the original source).
By submitting, I understand that this example is made available under these licenses: Public Domain and Odin's BSD-3 license. Only for third-party dependencies are other licenses allowed.

karl-zylinski

Hi. Thanks for the PR.

There are a bunch of unnecessary type specifications that I think came along from the C code. Such as this:
hvelLength: f32 = rl.Vector3Length(hvel)

Just use hvelLength := rl.Vector3Length(hvel)

Also, there is some weird "type double dipping" happening, such as this:
desiredDir: rl.Vector3 = rl.Vector3 {

Just do
desiredDir := rl.Vector3 {

I've only given a comment once for a specific issue, but most of them happen multiple times, so please look through the file.

Also, I've set up a style guide for the examples repository. Future PRs will have it linked in the template: https://github.com/odin-lang/examples/wiki/Naming-and-style-convention

karl-zylinski · 2025-10-02T22:01:46Z

raylib/ports/core/core_3d_camera_fps.odin

+		}
+	}
+
+	TOWER_SIZE: rl.Vector3 : rl.Vector3{16.0, 32.0, 16.0}


TOWER_SIZE :: rl.Vector3{16.0, 32.0, 16.0}

karl-zylinski · 2025-10-02T22:02:17Z

raylib/ports/core/core_3d_camera_fps.odin

+		}
+	}
+
+	delta: f32 = rl.GetFrameTime()


Use type inference delta := rl.GetFrameTime()

karl-zylinski · 2025-10-02T22:02:32Z

raylib/ports/core/core_3d_camera_fps.odin

+		body.velocity.y -= GRAVITY * delta
+	}
+
+	if (body.isGrounded && jumpPressed) {


Extra parens

karl-zylinski · 2025-10-02T22:03:51Z

raylib/ports/core/core_3d_camera_fps.odin

+// Draw game level
+draw_level :: proc() {
+	FLOOR_EXTENT: int : 25
+	TILE_SIZE: f32 : 5.0


Just do TILE_SIZE :: 5. It'll implicitly cast correctly when you use it.

karl-zylinski · 2025-10-02T22:06:14Z

raylib/ports/core/core_3d_camera_fps.odin

+		lookRotation.x -= mouseDelta.x * sensitivity.x
+		lookRotation.y += mouseDelta.y * sensitivity.y
+
+		sideway := i8(i8(rl.IsKeyDown(.D)) - i8(rl.IsKeyDown(.A)))


Both are i8. The outer cast does nothing.

GCodergr · 2025-10-03T05:31:44Z

Hi. Thanks for the PR.

There are a bunch of unnecessary type specifications that I think came along from the C code. Such as this: hvelLength: f32 = rl.Vector3Length(hvel)

Just use hvelLength := rl.Vector3Length(hvel)

Also, there is some weird "type double dipping" happening, such as this: desiredDir: rl.Vector3 = rl.Vector3 {

Just do desiredDir := rl.Vector3 {

I've only given a comment once for a specific issue, but most of them happen multiple times, so please look through the file.

Also, I've set up a style guide for the examples repository. Future PRs will have it linked in the template: https://github.com/odin-lang/examples/wiki/Naming-and-style-convention

Once again, thank you Karl for all the suggestions! ❤️

The style guide is really helpful, especially for someone who writes code in multiple languages.

For the Raylib examples, I originally aimed for the structure to be close to the original C examples (one-to-one), but I agree it’s more important for the Odin examples to follow the recommended naming conventions and structure.

I’ll probably have some free time tomorrow to update the PR.

Much appreciated! 🙏

GCodergr · 2025-10-04T15:56:43Z

Updated the code based on the feedback and the naming and style conventions guide.

Used type inference where appropriate and explicitly assigned types in the remaining cases to avoid unnecessary casting.

Please let me know if there are any further changes needed.

Thank you Karl!

karl-zylinski

Thanks for the fixes. I put in a few more comments.

karl-zylinski · 2025-10-05T22:14:38Z

raylib/ports/core/core_3d_camera_fps.odin

+		fovy = 60.0,
+		projection = .PERSPECTIVE,
+		position = rl.Vector3 {
+		player.position.x,


Weird indent. Should probably be

position = player.position + {0, BOTTOM_HEIGHT + headLerp, 0}

karl-zylinski · 2025-10-05T22:15:58Z

raylib/ports/core/core_3d_camera_fps.odin

+
+		delta := rl.GetFrameTime()
+		headLerp = rl.Lerp(headLerp, (crouching ? CROUCH_HEIGHT : STAND_HEIGHT), 20.0 * delta)
+		camera.position = rl.Vector3 {


camera.position = player.position + {0, BOTTOM_HEIGHT + headLerp, 0}

karl-zylinski · 2025-10-05T22:16:36Z

raylib/ports/core/core_3d_camera_fps.odin

+// Module Functions Definition
+//----------------------------------------------------------------------------------
+// Update body considering current world state
+update_body :: proc(body: ^Body,rot: f32, side: i8, forward: i8, jumpPressed: bool, crouchHold: bool) {


Body,rot missing space

karl-zylinski · 2025-10-05T22:17:21Z

raylib/ports/core/core_3d_camera_fps.odin

+	body.velocity.x = hvel.x
+	body.velocity.z = hvel.z
+
+	body.position.x += body.velocity.x * delta


body.position += body.velocity * delta

karl-zylinski · 2025-10-05T22:18:18Z

raylib/ports/core/core_3d_camera_fps.odin

+
+// Update camera for FPS behaviour
+update_camera_fps :: proc(camera: ^rl.Camera) {
+	up :: rl.Vector3{0.0, 1.0, 0.0}


I know this is a port so he camelCase for variables is OK, since the original does that. But all your other constants use SCREAMING_SNAKE_CASE. So this should either be a variable or be named UP

karl-zylinski · 2025-10-05T22:19:24Z

raylib/ports/core/core_3d_camera_fps.odin

+	// Clamp view up
+	maxAngleUp := rl.Vector3Angle(up, yaw)
+	maxAngleUp -= 0.001 // Avoid numerical errors
+	if (-(lookRotation.y) > maxAngleUp) {lookRotation.y = -maxAngleUp}


Here you do a single line. A few lines below you split it into several lines. Also this has unneeded parens on the condition.

karl-zylinski · 2025-10-05T22:21:43Z

raylib/ports/core/core_3d_camera_fps.odin

+draw_level :: proc() {
+	FLOOR_EXTENT :: 25
+	TILE_SIZE :: 5.0
+	TILE_COLOR_1 := rl.Color{150, 200, 200, 255}


Not a constant, yet it has constant naming

karl-zylinski · 2025-10-05T22:22:28Z

raylib/ports/core/core_3d_camera_fps.odin

+	TILE_COLOR_1 := rl.Color{150, 200, 200, 255}
+
+	// Floor tiles
+	for y: int = -FLOOR_EXTENT; y < FLOOR_EXTENT; y += 1 {


you could do

for y in -FLOOR_EXTENT..<FLOOR_EXTENT { for x in -FLOOR_EXTENT..<FLOOR_EXTENT {

I understand this is a port. But anyways, if you feel like you prefer it, then change it. Always nice to show odin features etc.

karl-zylinski · 2025-10-05T22:24:08Z

raylib/ports/core/core_3d_camera_fps.odin

+	rl.DrawCubeWiresV(towerPos, TOWER_SIZE, rl.DARKBLUE)
+
+	// Red sun
+	rl.DrawSphere(rl.Vector3{300.0, 300.0, 0.0}, 100, rl.Color{255, 0, 0, 255})


Drop the rl.Vector3 and rl.Color: Just write

`rl.DrawSphere({300.0, 300.0, 0.0}, 100, {255, 0, 0, 255})

karl-zylinski · 2025-10-05T22:25:34Z

raylib/ports/core/core_3d_camera_fps.odin

+			rl.DrawText("Camera controls:", 15, 15, 10, rl.BLACK)
+			rl.DrawText("- Move keys: W, A, S, D, Space, Left-Ctrl", 15, 30, 10, rl.BLACK)
+			rl.DrawText("- Look around: arrow keys or mouse", 15, 45, 10, rl.BLACK)
+			rl.DrawText(rl.TextFormat("- Velocity Len: (%06.3f)", rl.Vector2Length(rl.Vector2{player.velocity.x, player.velocity.z})), 15, 60, 10, rl.BLACK)


rl.Vector2Length(player.velocity.xz)

karl-zylinski · 2025-10-05T22:27:38Z

raylib/ports/core/core_3d_camera_fps.odin

+sensitivity := rl.Vector2{0.001, 0.001}
+
+player: Body
+lookRotation := rl.Vector2{0.0, 0.0}


lookRotation: rl.Vector2

karl-zylinski · 2025-10-05T22:28:00Z

raylib/ports/core/core_3d_camera_fps.odin

+
+player: Body
+lookRotation := rl.Vector2{0.0, 0.0}
+headTimer: f32 = 0.0


headTimer: f32 etc etc on these lines below

GCodergr · 2025-10-06T07:28:02Z

Thanks again for the comments!

I’ll try to find some time in the next few days to make the fixes.

The code was originally ported from the C example, so some C-style conventions slipped through.

It’s a good practice to replace those with more Odin-oriented features, especially in a public repository.

Appreciate the feedback, take care!

GCodergr added 2 commits September 7, 2025 16:58

Added core_3d_camera_fps.odin example

7515034

Removed deprecated comment

105f580

karl-zylinski reviewed Oct 2, 2025

View reviewed changes

GCodergr added 2 commits October 4, 2025 18:48

Refactored code based on feedback, naming and style conventions

6abe07e

Merge branch 'master' into master

c743181

karl-zylinski reviewed Oct 5, 2025

View reviewed changes

Added core_3d_camera_fps.odin example #129

Are you sure you want to change the base?

Added core_3d_camera_fps.odin example #129

Uh oh!

Conversation

GCodergr commented Sep 7, 2025

Uh oh!

karl-zylinski left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GCodergr commented Oct 3, 2025

Uh oh!

GCodergr commented Oct 4, 2025

Uh oh!

karl-zylinski left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GCodergr commented Oct 6, 2025

Uh oh!

Uh oh!