Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler segfault on abs(no_return_value()) #4508

Closed
dayllenger opened this issue Nov 23, 2024 · 1 comment · Fixed by #4516
Closed

Compiler segfault on abs(no_return_value()) #4508

dayllenger opened this issue Nov 23, 2024 · 1 comment · Fixed by #4516
Labels
bug frontend replicated We were able to replicate the bug.

Comments

@dayllenger
Copy link

Context

Odin:    dev-2024-11:e607cbe93
OS:      Arch Linux, Linux 6.6.60-1-lts
CPU:     Intel(R) Core(TM) i5-10210U CPU @ 1.60GHz
RAM:     7686 MiB
Backend: LLVM 18.1.8

Steps to Reproduce

package main

main :: proc() {
	p :: proc() {}
	abs(p())
}

$ odin build .
segmentation fault (core dumped)

Also fails with min, max, and some other builtin functions.
@Kelimion Kelimion added bug frontend replicated We were able to replicate the bug. labels Nov 25, 2024
Kelimion added a commit to Kelimion/Odin that referenced this issue Nov 25, 2024
@Kelimion
Fix odin-lang#4508 for abs, min, max
8aa6b4a
@Kelimion
Copy link
Member

Fixed in #4516. I'm looking over other builtins before I merge it.

@Kelimion Kelimion mentioned this issue Nov 25, 2024
Merged
Kelimion added a commit that referenced this issue Nov 25, 2024
@Kelimion
Fix #4508 for abs, min, max (#4516)
7c3ce33 
* Fix #4508 for abs, min, max and the rest of the builtins.

None of these segfault now:
```odin
package bug

main :: proc() {
	p :: proc() {}

	// _ = len(p())
	// _ = cap(p())

	// _ = size_of(p())
	// _ = align_of(p())

	// T :: struct {}
	// _ = offset_of(p())
	// _ = offset_of(T, p())
	// _ = offset_of(p(), foo)
	// _ = offset_of(p(), "")

	// _ = type_of(p())
	// _ = type_info_of(p())
	// _ = typeid_of(p())

	// A: [4]int
	// _ = swizzle(p())    //  :: proc(x: [N]T, indices: ..int) -> [len(indices)]T ---
	// _ = swizzle(A, p()) //  :: proc(x: [N]T, indices: ..int) -> [len(indices)]T ---

	// _ = complex(p(), p())
	// _ = quaternion(p(), p(), p(), p())
	// _ = quaternion(w=p(), x=p(), y=p(), z=p())

	// _ = real(p())
	// _ = imag(p())
	// _ = jmag(p())
	// _ = kmag(p())
	// _ = conj(p())

	// _ = expand_values(p())

	// _ = min(p())
	// _ = max(p())
	// _ = abs(p())
	// _ = clamp(p(), p(), p())

	// _ = soa_zip(p())
	// _ = soa_unzip(p())
}
```
FourteenBrush pushed a commit to FourteenBrush/Odin that referenced this issue Nov 30, 2024
@Kelimion @FourteenBrush
Fix odin-lang#4508 for abs, min, max (odin-lang#4516)
ef2ee69 
* Fix odin-lang#4508 for abs, min, max and the rest of the builtins.

None of these segfault now:
```odin
package bug

main :: proc() {
	p :: proc() {}

	// _ = len(p())
	// _ = cap(p())

	// _ = size_of(p())
	// _ = align_of(p())

	// T :: struct {}
	// _ = offset_of(p())
	// _ = offset_of(T, p())
	// _ = offset_of(p(), foo)
	// _ = offset_of(p(), "")

	// _ = type_of(p())
	// _ = type_info_of(p())
	// _ = typeid_of(p())

	// A: [4]int
	// _ = swizzle(p())    //  :: proc(x: [N]T, indices: ..int) -> [len(indices)]T ---
	// _ = swizzle(A, p()) //  :: proc(x: [N]T, indices: ..int) -> [len(indices)]T ---

	// _ = complex(p(), p())
	// _ = quaternion(p(), p(), p(), p())
	// _ = quaternion(w=p(), x=p(), y=p(), z=p())

	// _ = real(p())
	// _ = imag(p())
	// _ = jmag(p())
	// _ = kmag(p())
	// _ = conj(p())

	// _ = expand_values(p())

	// _ = min(p())
	// _ = max(p())
	// _ = abs(p())
	// _ = clamp(p(), p(), p())

	// _ = soa_zip(p())
	// _ = soa_unzip(p())
}
```
flysand7 pushed a commit to flysand7/Odin that referenced this issue Dec 1, 2024
@Kelimion @flysand7
Fix odin-lang#4508 for abs, min, max (odin-lang#4516)
0e35729 
* Fix odin-lang#4508 for abs, min, max and the rest of the builtins.

None of these segfault now:
```odin
package bug

main :: proc() {
	p :: proc() {}

	// _ = len(p())
	// _ = cap(p())

	// _ = size_of(p())
	// _ = align_of(p())

	// T :: struct {}
	// _ = offset_of(p())
	// _ = offset_of(T, p())
	// _ = offset_of(p(), foo)
	// _ = offset_of(p(), "")

	// _ = type_of(p())
	// _ = type_info_of(p())
	// _ = typeid_of(p())

	// A: [4]int
	// _ = swizzle(p())    //  :: proc(x: [N]T, indices: ..int) -> [len(indices)]T ---
	// _ = swizzle(A, p()) //  :: proc(x: [N]T, indices: ..int) -> [len(indices)]T ---

	// _ = complex(p(), p())
	// _ = quaternion(p(), p(), p(), p())
	// _ = quaternion(w=p(), x=p(), y=p(), z=p())

	// _ = real(p())
	// _ = imag(p())
	// _ = jmag(p())
	// _ = kmag(p())
	// _ = conj(p())

	// _ = expand_values(p())

	// _ = min(p())
	// _ = max(p())
	// _ = abs(p())
	// _ = clamp(p(), p(), p())

	// _ = soa_zip(p())
	// _ = soa_unzip(p())
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug frontend replicated We were able to replicate the bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #4508 for abs, min, max Kelimion/Odin
2 participants
@Kelimion @dayllenger