feat: start agent as a function that receive span processor #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edeNFed
approved these changes
Sep 21, 2024
blumamir
added a commit
to odigos-io/odigos
that referenced
this pull request
Sep 21, 2024
See odigos-io/opentelemetry-node#13 This PR starts the nodejs agent by calling a function, and supplying the distro name `'odigos-native-community'`, and a span processor for the community tier that uses batch span processor with OTLP exporter. CI will pass once we merge the node agent PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that the code in
autoinstrument.tswill not start instrumentation itself. Now starting the agent is a function which implementations can use. for example: the "native-community" distro will use a batch span processor with OTLP exporter, and send it's name to be populated in the resource attribute ("odigos-native-community")For eBPF instrumentation, this will allow us to use the same code, and only set the name and span processor to those we need there