Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove github token from makefile as they are unused #801

Merged
merged 1 commit into from
Dec 3, 2023
Merged

chore: remove github token from makefile as they are unused #801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
.PHONY: build-images
build-images:
docker build -t keyval/odigos-autoscaler:$(TAG) . --build-arg SERVICE_NAME=autoscaler --build-arg GITHUB_TOKEN=${GITHUB_TOKEN}
docker build -t keyval/odigos-scheduler:$(TAG) . --build-arg SERVICE_NAME=scheduler --build-arg GITHUB_TOKEN=${GITHUB_TOKEN}
docker build -t keyval/odigos-odiglet:$(TAG) . -f odiglet/Dockerfile --build-arg GITHUB_TOKEN=${GITHUB_TOKEN}
docker build -t keyval/odigos-instrumentor:$(TAG) . --build-arg SERVICE_NAME=instrumentor --build-arg GITHUB_TOKEN=${GITHUB_TOKEN}
docker build -t keyval/odigos-autoscaler:$(TAG) . --build-arg SERVICE_NAME=autoscaler
docker build -t keyval/odigos-scheduler:$(TAG) . --build-arg SERVICE_NAME=scheduler
docker build -t keyval/odigos-odiglet:$(TAG) . -f odiglet/Dockerfile
docker build -t keyval/odigos-instrumentor:$(TAG) . --build-arg SERVICE_NAME=instrumentor

.PHONY: push-images
push-images:
Expand All @@ -21,9 +21,9 @@ load-to-kind:

.PHONY: debug-odiglet
debug-odiglet:
docker build -t keyval/odigos-odiglet:$(TAG) . -f odiglet/debug.Dockerfile --build-arg GITHUB_TOKEN=${GITHUB_TOKEN}
docker build -t keyval/odigos-odiglet:$(TAG) . -f odiglet/debug.Dockerfile
kind load docker-image keyval/odigos-odiglet:$(TAG)
kubectl rollout restart daemonset odiglet -n odigos-system
kubectl wait --for=condition=ready pod -l app=odiglet -n odigos-system
$(eval POD_NAME := $(shell kubectl get pods -n odigos-system -l app=odiglet -o jsonpath='{.items[0].metadata.name}'))
$(eval POD_NAME := $(shell kubectl get pods -n odigos-system --field-selector=status.phase=Running -l app=odiglet -o jsonpath='{.items[0].metadata.name}'))
kubectl port-forward -n odigos-system $(POD_NAME) 2345:2345