feat: allow adding extra reconcilers to odiglet

cli/cmd/resources/odiglet.go

@@ -165,6 +165,17 @@ func NewOdigletClusterRole(psp bool) *rbacv1.ClusterRole {
 					"namespaces",
 				},
 			},
+			{
+				Verbs: []string{
+					"get",
+					"list",
+					"watch",
+				},
+				APIGroups: []string{"odigos.io"},
+				Resources: []string{
+					"instrumentationconfigs",
+				},
+			},
 		},
 	}
 

odiglet/cmd/main.go

@@ -48,9 +48,20 @@ func main() {
 
 	go startDeviceManager(clientset)
 
-	ctx := signals.SetupSignalHandler()
+	mgr, err := kube.CreateManager()
+	if err != nil {
+		log.Logger.Error(err, "Failed to create controller-runtime manager")
+		os.Exit(-1)
+	}
 
-	err = kube.StartReconciling(ctx, ebpfDirectors)
+	err = kube.SetupWithManager(mgr, ebpfDirectors)
+	if err != nil {
+		log.Logger.Error(err, "Failed to setup controller-runtime manager")
+		os.Exit(-1)
+	}
+
+	ctx := signals.SetupSignalHandler()
+	err = kube.StartManager(ctx, mgr)
 	if err != nil {
 		log.Logger.Error(err, "Failed to start controller-runtime manager")
 		os.Exit(-1)

odiglet/pkg/kube/manager.go

@@ -28,20 +28,30 @@ func init() {
 	utilruntime.Must(odigosv1.AddToScheme(scheme))
 }
 
-func StartReconciling(ctx context.Context, ebpfDirectors map[common.ProgrammingLanguage]ebpf.Director) error {
+func CreateManager() (ctrl.Manager, error) {
 	log.Logger.V(0).Info("Starting reconcileres for runtime details")
 	ctrl.SetLogger(log.Logger)
-	mgr, err := manager.New(config.GetConfigOrDie(), manager.Options{
+	return manager.New(config.GetConfigOrDie(), manager.Options{
 		Scheme: scheme,
 		Metrics: metricsserver.Options{
 			BindAddress: "0",
 		},
 	})
-	if err != nil {
-		return err
-	}
+}
+
+func StartManager(ctx context.Context, mgr ctrl.Manager) error {
+	go func() {
+		err := mgr.Start(ctx)
+		if err != nil {
+			log.Logger.Error(err, "error starting kube manager")
+		}
+	}()
 
-	err = runtime_details.SetupWithManager(mgr)
+	return nil
+}
+
+func SetupWithManager(mgr ctrl.Manager, ebpfDirectors map[common.ProgrammingLanguage]ebpf.Director) error {
+	err := runtime_details.SetupWithManager(mgr)
 	if err != nil {
 		return err
 	}
@@ -51,12 +61,5 @@ func StartReconciling(ctx context.Context, ebpfDirectors map[common.ProgrammingL
 		return err
 	}
 
-	go func() {
-		err := mgr.Start(ctx)
-		if err != nil {
-			log.Logger.Error(err, "error starting kube manager")
-		}
-	}()
-
 	return nil
 }