Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: sidebar interaction by onclick #751

Merged
merged 7 commits into from
Nov 12, 2023
Merged

refactor: sidebar interaction by onclick #751

merged 7 commits into from
Nov 12, 2023

Conversation

HeetVekariya
Copy link
Contributor

Fixes Issue:


Changes made:

  • Refactored code to interact with sidebar using onClick instead onHover

Files changed:

  • menu.tsx (frontend/webapp/components/side.menu/menu/menu.tsx)
  • menu.styled.tsx (frontend/webapp/components/side.menu/menu/menu.styled.tsx)

  • Tested the code

@HeetVekariya HeetVekariya requested a review from a team as a code owner November 9, 2023 10:35
alonkeyval
alonkeyval approved these changes Nov 12, 2023
View reviewed changes
Copy link
Collaborator

@alonkeyval alonkeyval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeetVekariya LGTM

@alonkeyval alonkeyval merged commit 817c599 into odigos-io:main Nov 12, 2023
5 checks passed
@HeetVekariya
Copy link
Contributor Author

@alonkeyval Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonkeyval alonkeyval alonkeyval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeetVekariya @alonkeyval