Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add useKeyDown hook #584

Merged
merged 9 commits into from
Oct 18, 2023
Merged

feat: add useKeyDown hook #584

merged 9 commits into from
Oct 18, 2023

Conversation

Kritik-J
Copy link
Contributor

@Kritik-J Kritik-J commented Oct 4, 2023

Resolves: #568

@Kritik-J Kritik-J requested a review from a team as a code owner October 4, 2023 09:47
@alonkeyval
Copy link
Collaborator

@Kritik-J please implement the new hook in the relevant files in addition to the hook implementation

alonkeyval
alonkeyval approved these changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@alonkeyval alonkeyval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blumamir
Copy link
Collaborator

@Kritik-J - the CI seems to fail, can you please take a look?
Thanks

#21 39.30 1:44  Error: Strings must use singlequote.  quotes
#21 39.30 7:8  Error: Strings must use singlequote.  quotes
#21 39.30 14:8  Error: Strings must use singlequote.  quotes
#21 39.30 15:30  Error: Strings must use singlequote.  quotes
#21 39.30 16:23  Error: Strings must use singlequote.  quotes
#21 39.30 17:33  Error: Strings must use singlequote.  quotes
#21 39.30 18:23  Error: Strings must use singlequote.  quotes
#21 39.30 19:19  Error: Strings must use singlequote.  quotes
#21 39.30 20:28  Error: Strings must use singlequote.  quotes
#21 39.30 40:9  Error: Strings must use singlequote.  quotes
#21 39.30 41:9  Error: Strings must use singlequote.  quotes
#21 39.30 42:9  Error: Strings must use singlequote.  quotes
#21 39.30 54:29  Error: Strings must use singlequote.  quotes

@Kritik-J
Copy link
Contributor Author

@blumamir please review

@blumamir blumamir merged commit f443273 into odigos-io:main Oct 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonkeyval alonkeyval alonkeyval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Reusable useKeyDown Hook for Keyboard Event Handling
3 participants
@Kritik-J @alonkeyval @blumamir