instrumentor: Combine startlangdetection and deleteinstrumentationconfig controllers into one sourceinstrumentation controller
#2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damemi
force-pushed
the
instrumentor-controllers
branch
6 times, most recently
from
c2c91c3 to
16ad956
Compare
…tation controller
damemi
force-pushed
the
instrumentor-controllers
branch
from
fdea8b8 to
5318029
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having 2 separate controllers to handle enabling and disabling instrumentation has led to race conditions and weird, hard to debug edge cases. Generally, having multiple controllers reconcile the same object can lead to these issues.
This combines them into one controller that receives all relevant events for enabling and disabling instrumentation. Based on the state of the relevant objects (essentially whether they are backed by a Source CR), the code branches within this controller to reconcile the appropriate action.
This also consolidates the separate finalizers that were spread between the 2 controllers into a single Source finalizer, reducing the risk of deadlock.