[GEN-1485] fix: num of selected app bug #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntainer Task 149 sources container
…play-source-manage-list
…urces-card Task 107 overview sources card
…rce-manage-list Task 142 display source manage list
…rce-btn Task 143 add new source btn
…sources-connection Task 145 handle new sources connection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to update UI labels, improve data filtering logic, and standardize code formatting. The most important changes include modifying the title in the
SelectSourcesContainer, updating the filtering logic inuseSectionData, and enhancing theEMPTY_SOURCEmessage.UI Label Updates:
frontend/webapp/containers/main/sources/choose.sources/index.tsx: Changed the title inOverviewHeaderfromOVERVIEW.MENU.SOURCEStoOVERVIEW.ADD_NEW_SOURCE.frontend/webapp/utils/constants/string.tsx: Updated theEMPTY_SOURCEmessage to be more descriptive by adding "in this namespace".Data Filtering Logic:
frontend/webapp/hooks/useSectionData.tsx: Enhanced the filtering logic inuseSectionDatato exclude items withapp_instrumentation_labeledset to true.Code Formatting:
frontend/webapp/hooks/useSectionData.tsx: Standardized import statements to use single quotes instead of double quotes.