Webhook injection no kubelet #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edeNFed
reviewed
Oct 7, 2024
blumamir
approved these changes
Oct 7, 2024
RonFed
reviewed
Oct 7, 2024
RonFed
approved these changes
Oct 7, 2024
tamirdavid1
force-pushed
the
webhook-injection-no-kubelet
branch
from
8bbf2eb
to
8ee6a28
Compare
blumamir
reviewed
Oct 7, 2024
tamirdavid1
force-pushed
the
webhook-injection-no-kubelet
branch
from
4a52582
to
94feec6
Compare
edeNFed
approved these changes
Oct 7, 2024
blumamir
reviewed
Oct 7, 2024
tamirdavid1
force-pushed
the
webhook-injection-no-kubelet
branch
from
396c38c
to
ca433be
Compare
blumamir
approved these changes
Oct 7, 2024
tamirdavid1
force-pushed
the
webhook-injection-no-kubelet
branch
from
23ea708
to
5fd1dbd
Compare
tamirdavid1
force-pushed
the
webhook-injection-no-kubelet
branch
from
706972a
to
15223f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to enhance the debugging setup, improve environment variable handling, and refactor code for better readability and maintainability. The most important changes include updates to the debugging configuration, injection of environment variables, and refactoring of workload handling.
Debugging Enhancements:
.vscode/launch.json: Added environment variables for local mutating webhook certificate directory to facilitate local debugging.CONTRIBUTING.md: Added detailed instructions for debugging the Instrumentor when the Mutating Webhook is enabled.Environment Variable Injection:
instrumentor/controllers/instrumentationdevice/pods_webhook.go: Introduced constants for ODIGOS environment variables and added a function to inject these variables into all containers. [1] [2]instrumentor/main.go: Added logic to check for a local webhook certificate directory and configure the WebhookServer accordingly for local development. [1] [2]Refactoring:
k8sutils/pkg/workload/ownerreference.go: Refactored workload handling functions to separate concerns and improve readability.opampserver/pkg/server/handlers.go: Refactored theOnNewConnectionmethod to extract and handle agent attributes more efficiently and added helper functions for resolving Kubernetes attributes. [1] [2] [3] [4] [5]Minor Imports Adjustments:
instrumentor/main.go: Added missing import forwebhookpackage.opampserver/pkg/server/handlers.go: Aliased thedeviceidimport for consistency.These changes collectively improve the development experience and code maintainability.