feat: Java workload e2e #1539
Merged
feat: Java workload e2e #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yodigos
force-pushed
the
java-workload-e2e
branch
from
e24be97
to
00670ab
Compare
blumamir
reviewed
Sep 29, 2024
There was a problem hiding this comment.
Please write a description about the scenarios here.
I see we don't have any tests for unsupported or old versions. Since this is where many problems are manifested, I think it even more important to test these then the mainstream version.
Also, please add a test for java latests version, as if something breaks with new versions, we will not have any other indication. Should we also test the minimum version?
tests/e2e/workload-lifecycle/services/java-http-server/java-supported-version.Dockerfile
Show resolved
Hide resolved
tests/e2e/workload-lifecycle/services/java-http-server/java-supported-docker-env.Dockerfile
Show resolved
Hide resolved
blumamir
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.