fix: remove only protected c files and their directories #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edeNFed
reviewed
Aug 13, 2024
edeNFed
approved these changes
Aug 13, 2024
edeNFed
reviewed
Aug 13, 2024
| shouldRecreateCFiles := ShouldRecreateAllCFiles() | ||
| log.Logger.V(0).Info(fmt.Sprintf("Removing files in directory: %s, shouldRecreateCFiles: %s", hostDir, fmt.Sprintf("%t", shouldRecreateCFiles))) | ||
| log.Logger.V(0).Info(fmt.Sprintf("Removing files in directory: %s, shouldRecreateCFiles: %t", hostDir, shouldRecreateCFiles)) |
There was a problem hiding this comment.
nit: probably better to use structured logging (arguments as key-value pairs instead of one formatted string)
tamirdavid1
force-pushed
the
not-removing-only-c-files-and-their-dirs
branch
from
6af7dc3
to
19b2883
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During an issue with eBPF instrumentation breaking upon odiglet restarts, I implemented a "smart" recreation of instrumentation files. The goal was to retain compiled C files when odiglet restarted. However, this approach led to other files not being properly recreated in certain cases. For example, if the instrumentation version was upgraded, the host filesystem could end up with both versions, which caused problems, especially in Python.
This PR addresses the issue by ensuring that everything is deleted and recreated except for the C files and their directories. For instance, in
/var/odigos/python-ebpf/, everything will be recreated except forpythonUSDT.abi3.so.