feat: migrate helm charts repo from odigos-charts to here #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauno56
force-pushed
the
feat/migrate-helm
branch
4 times, most recently
from
f88506a
to
d61b5d3
Compare
rauno56
force-pushed
the
feat/migrate-helm
branch
from
d61b5d3
to
6670bf4
Compare
edeNFed
reviewed
Aug 8, 2024
| # Retry to avoid flakiness (due to CRD race conditions in helm). Timeout after 60s. | ||
| while ! helm upgrade --install odigos /tmp/odigos-charts/charts/odigos --create-namespace --namespace odigos-test-ns --set image.tag=e2e-test; do | ||
| while ! helm upgrade --install odigos $GITHUB_WORKSPACE/helm/odigos --create-namespace --namespace odigos-test-ns --set image.tag=e2e-test; do |
There was a problem hiding this comment.
nit: I used /tmp to easily be able to run chainsaw tests locally outside Github Actions
There was a problem hiding this comment.
I understand that.
We need to somehow find the project root. Chainsaw just changes the current working directory and, outside of GHA, I don't even know how to retrieve it.
Do you know a way to reference project root in chainsaw tests that is not GHA-specific?
Alternatively we could just hardcode ../../ and have the tests break when there are changes in chainsaw structure.
EDIT: Now thinking about it, I think making it work locally is more valuable than making it resistant to folder structure changes. I'll make that change. Thanks for pointing this out! 🙏
edeNFed
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging this we will be managing helm charts in this repo fully. The old index will then stay up and working but will be stale.
This has a benefit of being able to update helm and code in the same PR, simplifying the whole release process and having e2e tests run on the latest unreleased helm version.
This PR will also change the chart versioning(currently
0.3.x) to match the application version(currently1.0.x) on every release.This includes 2bd8d7b of odigos-charts which is the last commit at the moment of creation of this PR.
Commits: