-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set this repo up for a Helm chart registry #1362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edeNFed
approved these changes
Jul 17, 2024
rauno56
changed the title
Set this repo up for a Helm chart registry
feat: set this repo up for a Helm chart registry
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot properly test the new workflow because of the very intricate setup with dispatches and everything. Thus I added the workflow here for testing.
❗ The workflow will be run and assets produced and uploaded to the release under "test-helm-assets-odigos.tgz". These assets will not be available through our current Helm Chart index. Anyone using our helm charts will not be affected with this PR. The current mode of Helm chart development completely stays the same. This contribution is solely for setting up a parallel workflow for testing.
Notable changes:
image.tag
values so that there's one less thing to mess up while releasing charts.