fix: rate limit node collector restarts on config change #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… seconds and after 20 seconds.
yodigos
commented
Jul 16, 2024
yodigos
commented
Jul 16, 2024
yodigos
commented
Jul 16, 2024
| @@ -57,18 +66,17 @@ func syncDataCollection(instApps *odigosv1.InstrumentedApplicationList, dests *o | |||
| logger := log.FromContext(ctx) | |||
| logger.V(0).Info("Syncing data collection") | |||
|
|
|||
| configData, err := syncConfigMap(instApps, dests, processors, dataCollection, ctx, c, scheme) | |||
| _, err := syncConfigMap(instApps, dests, processors, dataCollection, ctx, c, scheme) | |||
There was a problem hiding this comment.
I calculate this later -> when that patch triggers
RonFed
reviewed
Jul 16, 2024
| } | ||
|
|
||
| // runFunctionWithDelayAndSkipNewCalls runs the function with the specified delay and skips new calls until the function execution is finished | ||
| func (dm *DelayManager) runFunctionWithDelayAndSkipNewCalls(delay time.Duration, fn func(args ...interface{}) (*appsv1.DaemonSet, error), fnArgs ...interface{}) { |
There was a problem hiding this comment.
I'd prefer to use a library function for this if possible.
Looks like https://pkg.go.dev/k8s.io/apimachinery@v0.30.2/pkg/util/wait#PollUntilContextTimeout might be relevant or other functions from that lib
RonFed
reviewed
Jul 16, 2024
blumamir
reviewed
Jul 16, 2024
|
|
||
| func getConfigMap(ctx context.Context, c client.Client, collectorGroup *odigosv1.CollectorsGroup) (*v1.ConfigMap, error) { | ||
| configMap := &v1.ConfigMap{} | ||
| if err := c.Get(ctx, client.ObjectKey{Namespace: collectorGroup.Namespace, Name: collectorGroup.Name}, configMap); err != nil { |
There was a problem hiding this comment.
you can use the config map name directly as in https://github.com/odigos-io/odigos/blob/main/k8sutils/pkg/consts/consts.go
blumamir
reviewed
Jul 17, 2024
| if err == nil { | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
should we log something if we run out of retries and give up?
otherwise, the error is silently dropped, right?
and should we also log something on success to aid debugging in case there are issues?
blumamir
changed the title
blumamir
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.