feat: opamp implementation for nodejs agent #1287
Conversation
|
nit: maybe we should put the files in |
| } | ||
| } | ||
|
|
||
| func (k *K8sPodInfoResolver) getServiceNameFromAnnotation(ctx context.Context, name string, kind string, namespace string) (string, bool) { |
There was a problem hiding this comment.
I think these functions should idealy be under k8sutils and not opampserver
There was a problem hiding this comment.
Will handle in a followup PR
opampserver/protobufs/anyvalue.pb.go
Outdated
There was a problem hiding this comment.
Are these generated with protoc, if so maybe worth adding in the README how to generate them,
Are we using the proto defined in opAmp, or are we having some custom types?
There was a problem hiding this comment.
The instructions can be found here: https://github.com/odigos-io/opamp-spec
| // unfortunately, I did not find a way to get just one device id from the kubelet, we need | ||
| // to list and iterate over all the devices to get a current snapshot of allocations on this node | ||
| // and then look for the ones we are interested in. | ||
| func (c *KubeletClient) DeviceIdsToContainerDetails() (map[string]*ContainerDetails, error) { |
There was a problem hiding this comment.
This also does not look like it relates specifically to opamp server, maybe worth moving to k8sutils
There was a problem hiding this comment.
Yes, I suggest doing it later on
| }); | ||
| } | ||
|
|
||
| private async sendHeartBeatToServer() { |
There was a problem hiding this comment.
Do we need the heartbeat to keep the connection alive or is it part of OpAMP spec? Maybe we can drop it if we are not doing anything on the heartbeat
There was a problem hiding this comment.
OpAMP server uses it to figure out if the process (or the connection) is down
No description provided.