-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve E2E tests #1265
Improve E2E tests #1265
Conversation
b776671
to
b7116ce
Compare
…into improve-e2e-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still reviewing, trying to run locally.
Few nit comments
content: | | ||
while true; do | ||
# Apply the job | ||
kubectl apply -f 05-generate-traffic.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we flush traces?
And why todo this process multiple times?
Don't we want to generate traffic and then just wait until the trace is ready?
Is it flaky or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question: Tempo is sort of eventually consistent, meaning you don't immediately get traces you just inserted in a query.
I force flush it so they are shown in the query without having to sleep until tempo persists the data.
docker pull keyval/odigos-demo-inventory:v0.1 | ||
docker pull keyval/odigos-demo-membership:v0.1 | ||
docker pull keyval/odigos-demo-coupon:v0.1 | ||
docker pull keyval/odigos-demo-inventory:v0.1 | ||
docker pull keyval/odigos-demo-frontend:v0.2 | ||
kind load docker-image keyval/odigos-demo-inventory:v0.1 | ||
kind load docker-image keyval/odigos-demo-membership:v0.1 | ||
kind load docker-image keyval/odigos-demo-coupon:v0.1 | ||
kind load docker-image keyval/odigos-demo-inventory:v0.1 | ||
kind load docker-image keyval/odigos-demo-frontend:v0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the image tag is not consistent (0.1 vs 0.2).
I think we should align with https://github.com/odigos-io/simple-demo/blob/main/kubernetes/deployment.yaml which is using v0.1.11. Can we simply kubectl apply
the simple demo deployment which we use for the getting started?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blumamir You can look in the other chainsaw file - I raised the same thing and Eden answered there.
- script: | ||
timeout: 60s | ||
content: | | ||
while true; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, let's copy this to a new file: generate_traffic.sh in the common directory.
So, we don't need to duplicate it with the other chainsaw-test.
And this file will be cleaner - only steps description without logic.
No description provided.