-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement rename action #1094
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauno56
force-pushed
the
feat/rename-action
branch
2 times, most recently
from
March 28, 2024 14:51
cedc1c3
to
ea75aa8
Compare
rauno56
force-pushed
the
feat/rename-action
branch
from
April 2, 2024 11:15
e3abc8e
to
40e5139
Compare
rauno56
force-pushed
the
feat/rename-action
branch
from
April 2, 2024 11:26
40e5139
to
66adbbc
Compare
blumamir
approved these changes
Apr 2, 2024
rauno56
added a commit
to rauno56/odigos-charts
that referenced
this pull request
Apr 2, 2024
rauno56
added a commit
to rauno56/odigos-charts
that referenced
this pull request
Apr 2, 2024
blumamir
added a commit
to odigos-io/odigos-charts
that referenced
this pull request
Apr 10, 2024
feat: add rename attribute manifests for odigos-io/odigos#1094
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented rename action that sets up transform processor with two rules:
set(attributes["<to>"], attributes["<from>"])
delete_key(attributes, "<from>")
Very analogous to delete attribute action.
Purposefully missing UI bits, perhaps @alonkeyval can take ownership for that while this is being reviewed and merged.
Example yaml for rename action: