Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement rename action #1094

Merged
merged 8 commits into from
Apr 2, 2024
Merged

Conversation

rauno56
Copy link
Contributor

@rauno56 rauno56 commented Mar 28, 2024

Implemented rename action that sets up transform processor with two rules:

  • set(attributes["<to>"], attributes["<from>"])
  • delete_key(attributes, "<from>")

Very analogous to delete attribute action.

Purposefully missing UI bits, perhaps @alonkeyval can take ownership for that while this is being reviewed and merged.

Example yaml for rename action:

apiVersion: actions.odigos.io/v1alpha1
kind: RenameAttribute
metadata:
  name: ra-9sz8q
  namespace: odigos-system
spec:
  actionName: Rename network attributes
  renames:
    net.peer.address: network.peer.address
    net.local.address: network.local.address
    net.peer.ip: network.peer.address
    net.host.ip: network.local.address
  signals:
  - LOGS
  - METRICS
  - TRACES

@rauno56 rauno56 force-pushed the feat/rename-action branch 2 times, most recently from cedc1c3 to ea75aa8 Compare March 28, 2024 14:51
@rauno56 rauno56 marked this pull request as ready for review April 2, 2024 10:50
@rauno56 rauno56 requested a review from a team as a code owner April 2, 2024 10:50
rauno56 added a commit to rauno56/odigos-charts that referenced this pull request Apr 2, 2024
rauno56 added a commit to rauno56/odigos-charts that referenced this pull request Apr 2, 2024
@blumamir blumamir merged commit 0bbc6a7 into odigos-io:main Apr 2, 2024
10 checks passed
@rauno56 rauno56 deleted the feat/rename-action branch April 2, 2024 11:46
blumamir added a commit to odigos-io/odigos-charts that referenced this pull request Apr 10, 2024
This was referenced Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants